Skip to content

fix(InfrastructureIcons): replaced with RH brand icons part 5#12505

Open
thatblindgeye wants to merge 2 commits into
patternfly:mainfrom
thatblindgeye:iss12399_part5
Open

fix(InfrastructureIcons): replaced with RH brand icons part 5#12505
thatblindgeye wants to merge 2 commits into
patternfly:mainfrom
thatblindgeye:iss12399_part5

Conversation

@thatblindgeye

@thatblindgeye thatblindgeye commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

What: Towards #12399

Updates Cogs, Keys, ResourceFull, Lock, and LockOpen icons

Additional issues:

Summary by CodeRabbit

  • Documentation
    • Updated example code and documentation across multiple components (DescriptionList, List, ProgressStepper, Slider, and Wizard) to feature enhanced icon components. These changes improve visual consistency across examples, provide clearer implementation reference patterns, and demonstrate modern icon usage approaches for developers.

@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@thatblindgeye, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 1 minute and 15 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses rolling per-developer review limits. Reviews become available again as older review attempts age out of the rolling limit window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0856ec52-a1a9-48ee-922f-07032184d967

📥 Commits

Reviewing files that changed from the base of the PR and between 8e8188c and b980e26.

📒 Files selected for processing (1)
  • packages/react-core/src/components/ProgressStepper/__tests__/ProgressStep.test.tsx

Walkthrough

Multiple icon imports across DescriptionList, List, ProgressStepper, Slider, and Wizard components are replaced with their RhUi-prefixed equivalents (rh-ui-key-icon, rh-ui-lock-fill-icon, rh-ui-unlock-fill-icon, rh-ui-gear-group-fill, rh-ui-resources-full-icon). The ProgressStep production component's variantIcons.info mapping is updated; all other changes are in example components and markdown docs.

Changes

Icon migration to RhUi* variants

Layer / File(s) Summary
ProgressStep production icon change
packages/react-core/src/components/ProgressStepper/ProgressStep.tsx
Replaces ResourcesFullIcon with RhUiResourcesFullIcon in the variantIcons.info mapping of the production component.
DescriptionList icons-on-terms example and docs
packages/react-core/src/components/DescriptionList/examples/DescriptionListIconsOnTerms.tsx, packages/react-core/src/components/DescriptionList/examples/DescriptionList.md
Switches key icon import from key-icon to rh-ui-key-icon in the example component and updates the DescriptionListTerm icon prop; reflowed markdown doc block boundaries and section headings.
List icon examples update
packages/react-core/src/components/List/examples/List.md, packages/react-core/src/components/List/examples/ListIcons.tsx, packages/react-core/src/components/List/examples/ListLargeIcons.tsx
Replaces KeyIcon with RhUiKeyIcon for the second list item icon across both example components and the markdown docs.
Slider lock/unlock icon replacement
packages/react-core/src/components/Slider/examples/Slider.md, packages/react-core/src/components/Slider/examples/SliderActions.tsx
Replaces LockIcon/LockOpenIcon with RhUiLockFillIcon/RhUiUnlockFillIcon in the buildAction button render and markdown docs.
Wizard gear icon replacement across examples
packages/react-core/src/components/Wizard/examples/Wizard.md, packages/react-core/src/components/Wizard/examples/WizardValidateOnButtonPress.tsx, packages/react-core/src/components/Wizard/examples/WizardWithSubmitProgress.tsx, packages/react-core/src/deprecated/components/Wizard/examples/Wizard.md
Replaces CogsIcon with RhUiGearGroupFillIcon in the EmptyState icon prop across two Wizard example components and both current and deprecated markdown docs; adds useEffect to the Wizard.md React import.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

Needs design review

Suggested reviewers

  • nicolethoen
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and concisely describes the main change: replacing InfrastructureIcons with Red Hat brand icons as part 5 of a larger effort, which aligns with the changeset's focus on updating icons across multiple components.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@patternfly-build

patternfly-build commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

import RhMicronsExternalLinkIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-external-link-icon';
import SlackHashIcon from '@patternfly/react-icons/dist/esm/icons/slack-hash-icon';
import CogsIcon from '@patternfly/react-icons/dist/esm/icons/cogs-icon';
import RhUiGearGroupFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-gear-group-fill-icon';

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the icon used currently in org (I had to fix an import thing locally to see it, currently on org there's a reference error):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants