Skip to content

fix(InfrastructureIcons): replaced with RH brand icons part 2#12502

Open
thatblindgeye wants to merge 2 commits into
patternfly:mainfrom
thatblindgeye:iss12399_part2
Open

fix(InfrastructureIcons): replaced with RH brand icons part 2#12502
thatblindgeye wants to merge 2 commits into
patternfly:mainfrom
thatblindgeye:iss12399_part2

Conversation

@thatblindgeye

@thatblindgeye thatblindgeye commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

What: Towards #12399

Covers DesktopIcon, LaptopIcon, CloudIcon, and CubesIcon

Additional issues:

Summary by CodeRabbit

  • Documentation
    • Updated component example and demo documentation for Alert, EmptyState, List, Nav, and Tabs to use the latest icon components.
    • Refreshed Compass and Page demo markdown references to match the updated icon set.
  • Refactor
    • Updated example and demo implementations to swap displayed icons to the latest variants (while keeping layout and behavior unchanged), including Alert, EmptyState, List, Nav, Tabs, and related dock/navigation items.

@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a6af671c-c848-402a-be36-25f7ebf03ee9

📥 Commits

Reviewing files that changed from the base of the PR and between 9fd2d91 and b0fe821.

📒 Files selected for processing (21)
  • packages/react-core/src/components/Alert/examples/Alert.md
  • packages/react-core/src/components/Alert/examples/AlertCustomIcons.tsx
  • packages/react-core/src/components/EmptyState/examples/EmptyState.md
  • packages/react-core/src/components/EmptyState/examples/EmptyStateBasic.tsx
  • packages/react-core/src/components/EmptyState/examples/EmptyStateExtraLarge.tsx
  • packages/react-core/src/components/EmptyState/examples/EmptyStateExtraSmall.tsx
  • packages/react-core/src/components/EmptyState/examples/EmptyStateLarge.tsx
  • packages/react-core/src/components/EmptyState/examples/EmptyStateSmall.tsx
  • packages/react-core/src/components/List/examples/List.md
  • packages/react-core/src/components/List/examples/ListIcons.tsx
  • packages/react-core/src/components/List/examples/ListLargeIcons.tsx
  • packages/react-core/src/components/Nav/examples/Nav.md
  • packages/react-core/src/components/Nav/examples/NavIcons.tsx
  • packages/react-core/src/components/Tabs/examples/Tabs.md
  • packages/react-core/src/components/Tabs/examples/TabsIconAndText.tsx
  • packages/react-core/src/demos/Compass/Compass.md
  • packages/react-core/src/demos/Compass/examples/CompassDockDemo.tsx
  • packages/react-core/src/demos/Nav.md
  • packages/react-core/src/demos/Page.md
  • packages/react-core/src/demos/examples/Nav/NavDockedNav.tsx
  • packages/react-integration/demo-app-ts/src/components/demos/TableDemo/TableEmptyStateDemo.tsx
✅ Files skipped from review due to trivial changes (12)
  • packages/react-core/src/components/Nav/examples/Nav.md
  • packages/react-core/src/components/List/examples/ListIcons.tsx
  • packages/react-core/src/components/EmptyState/examples/EmptyStateSmall.tsx
  • packages/react-core/src/demos/Compass/examples/CompassDockDemo.tsx
  • packages/react-core/src/components/Tabs/examples/Tabs.md
  • packages/react-core/src/components/EmptyState/examples/EmptyStateBasic.tsx
  • packages/react-core/src/demos/Nav.md
  • packages/react-core/src/demos/Page.md
  • packages/react-integration/demo-app-ts/src/components/demos/TableDemo/TableEmptyStateDemo.tsx
  • packages/react-core/src/components/Alert/examples/Alert.md
  • packages/react-core/src/components/List/examples/ListLargeIcons.tsx
  • packages/react-core/src/components/Tabs/examples/TabsIconAndText.tsx
🚧 Files skipped from review as they are similar to previous changes (8)
  • packages/react-core/src/components/EmptyState/examples/EmptyStateExtraLarge.tsx
  • packages/react-core/src/components/List/examples/List.md
  • packages/react-core/src/components/Alert/examples/AlertCustomIcons.tsx
  • packages/react-core/src/demos/Compass/Compass.md
  • packages/react-core/src/components/EmptyState/examples/EmptyStateExtraSmall.tsx
  • packages/react-core/src/demos/examples/Nav/NavDockedNav.tsx
  • packages/react-core/src/components/EmptyState/examples/EmptyStateLarge.tsx
  • packages/react-core/src/components/Nav/examples/NavIcons.tsx

Walkthrough

Across 21 files in packages/react-core and packages/react-integration, four legacy PatternFly icon components (CloudIcon, CubesIcon, LaptopIcon, DesktopIcon) are replaced with their RH brand equivalents (RhUiCloudFillIcon, RhUiModuleIcon, RhUiLaptopFillIcon, RhUiDesktopIcon) in component examples, demos, and integration tests.

Changes

Icon Migration Across Examples and Demos

Layer / File(s) Summary
CloudIcon → RhUiCloudFillIcon in Nav, Compass, and Page demos
packages/react-core/src/components/Nav/examples/Nav.md, packages/react-core/src/components/Nav/examples/NavIcons.tsx, packages/react-core/src/demos/Compass/Compass.md, packages/react-core/src/demos/Compass/examples/CompassDockDemo.tsx, packages/react-core/src/demos/Nav.md, packages/react-core/src/demos/Page.md, packages/react-core/src/demos/examples/Nav/NavDockedNav.tsx
Nav, Compass, and Page markdown docs and TSX demo components swap the CloudIcon import and JSX reference for RhUiCloudFillIcon in all relevant nav icon slots.
CubesIcon → RhUiModuleIcon in EmptyState examples and Table integration demo
packages/react-core/src/components/EmptyState/examples/EmptyState.md, packages/react-core/src/components/EmptyState/examples/EmptyState*.tsx, packages/react-integration/demo-app-ts/src/components/demos/TableDemo/TableEmptyStateDemo.tsx
All five EmptyState size-variant examples plus the markdown doc and the TableEmptyStateDemo integration component replace CubesIcon with RhUiModuleIcon for the icon prop. The EmptyState.md also fixes a missing fence close and reformats code block markup.
LaptopIcon/DesktopIcon → RhUiLaptopFillIcon/RhUiDesktopIcon in Alert, Tabs, and List examples
packages/react-core/src/components/Alert/examples/Alert.md, packages/react-core/src/components/Alert/examples/AlertCustomIcons.tsx, packages/react-core/src/components/Tabs/examples/Tabs.md, packages/react-core/src/components/Tabs/examples/TabsIconAndText.tsx, packages/react-core/src/components/List/examples/List.md, packages/react-core/src/components/List/examples/ListIcons.tsx, packages/react-core/src/components/List/examples/ListLargeIcons.tsx
Alert, Tabs, and List markdown docs and TSX example components replace LaptopIcon with RhUiLaptopFillIcon and DesktopIcon with RhUiDesktopIcon in their respective icon props and JSX references.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related issues

Possibly related PRs

  • patternfly/patternfly-react#12376: Updates EmptyState snapshot tests to use RhUiModuleIcon instead of CubesIcon, overlapping with this PR's EmptyState example icon changes.
  • patternfly/patternfly-react#12403: Modifies packages/react-core/src/demos/Compass/Compass.md for frontmatter changes while this PR updates the same file's icon imports.
  • patternfly/patternfly-react#12483: Changes the same Tabs example files (Tabs.md and TabsIconAndText.tsx) by swapping icon imports/props for tab titles.

Suggested labels

Needs design review

Suggested reviewers

  • rebeccaalpert
  • kmcfaul
  • nicolethoen
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: replacing infrastructure icons (DesktopIcon, LaptopIcon, CloudIcon, CubesIcon) with Red Hat brand icons across multiple components and examples.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@patternfly-build

patternfly-build commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

@rebeccaalpert rebeccaalpert left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paged through the site + this and it looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants