fix(logging): correct RST signal-strength bars for dB-report digital modes

[patrickrb]

Problem

The new-contact logging form renders a small five-bar "signal strength" meter next to the sent/received RST fields. The helper that drives it, rstToBars, hard-coded its own list of digital modes:

const isDigital = ['FT8', 'FT4', 'PSK31', 'RTTY', 'MFSK', 'OLIVIA', 'CONTESTIA'].includes(mode);

That list had drifted behind the canonical DB_REPORT_MODES set in src/lib/modes.ts (the source of truth defaultRstForMode uses). When an operator selects JS8, FST4, JT65, JT9, Q65, MSK144, or PSK63, the form pre-fills a -10 dB report — but because rstToBars didn't recognize those as dB-report modes, it fell through to the voice/CW path and parsed the leading digit of -10 ("1") as an RST readability, drawing a misleading 1 bar instead of the correct dB-scaled meter (~2 bars for −10 dB).

This is the same class of drift the repo has repeatedly fixed for band and mode dropdowns: a hand-maintained list that silently falls out of step with the canonical src/lib module.

Solution

• Expose the dB-report classification as a canonical isDbReportMode(mode) from src/lib/modes.ts, backed by the existing DB_REPORT_MODES set. defaultRstForMode now calls it too, so the report the form fills and the meter that draws it can never disagree.
• Route rstToBars in src/app/new-contact/page.tsx through isDbReportMode instead of its own hard-coded list.

No behavior change for any mode that was already classified as digital (the new set is a strict superset); the fix only adds the WSJT-X/weak-signal and PSK63 modes that were missing.

Testing

• tests/modes.spec.ts — added an isDbReportMode suite (weak-signal family classified as dB, phone/CW/digital-voice/image classified as non-dB, case/whitespace tolerance) and an invariant that defaultRstForMode and isDbReportMode agree for every canonical mode. 16/16 mode tests pass.
• npm run typecheck — clean
• npm run lint — clean
• npm run build — compiled successfully

Scope / follow-up

Purely a client-side visualization fix plus the shared classifier; no schema, API, or stored-data changes, so it's fully backwards compatible. QuickLogCard doesn't render this meter, so no change was needed there.

🤖 Generated with Claude Code

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
nodelog	Ready	Preview, Comment	Jul 24, 2026 3:09pm