Fix Roku Dev Studio script typecheck resolution in CI - #65
Draft
Hareendra Donapati (hdonapati) with Copilot wants to merge 2 commits into
Draft
Fix Roku Dev Studio script typecheck resolution in CI#65Hareendra Donapati (hdonapati) with Copilot wants to merge 2 commits into
Hareendra Donapati (hdonapati) with Copilot wants to merge 2 commits into
Conversation
Copilot started work on behalf of
Hareendra Donapati (hdonapati)
September 2, 2026 04:43
View session
Co-authored-by: hdonapati <104085142+hdonapati@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix the failing GitHub Actions job
Fix Roku Dev Studio script typecheck resolution in CI
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI failure came from
typecheck:scriptstraversing renderer-adjacent imports with a scripts tsconfig that no longer matched the renderer graph. This change updates that path so script verification files can typecheck against renderer code without pulling in spurious TS errors.Align script typecheck with renderer import requirements
tsconfig.scripts.jsonto use the same modern target/module-resolution assumptions as the renderer-adjacent code it reacheswindow.rokusurface as renderer codeMake vendored ESM resolvable in standalone script typecheck
pretypecheck:scriptshook sotypecheck:scriptsprepares the generated renderer vendor files before TypeScript runsrenderer/vendor/tanstack-virtual-core.mjsso strict script typecheck can type the vendored ESM import directlyResulting behavior
{ "scripts": { "pretypecheck:scripts": "npm run pretypecheck:renderer", "typecheck:scripts": "tsc --noEmit -p tsconfig.scripts.json" } }