Skip to content

Fix Roku Dev Studio script typecheck resolution in CI - #65

Draft
Hareendra Donapati (hdonapati) with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-github-actions-job
Draft

Fix Roku Dev Studio script typecheck resolution in CI#65
Hareendra Donapati (hdonapati) with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-github-actions-job

Conversation

Copilot AI commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

The CI failure came from typecheck:scripts traversing renderer-adjacent imports with a scripts tsconfig that no longer matched the renderer graph. This change updates that path so script verification files can typecheck against renderer code without pulling in spurious TS errors.

  • Align script typecheck with renderer import requirements

    • update tsconfig.scripts.json to use the same modern target/module-resolution assumptions as the renderer-adjacent code it reaches
    • add the DOM/iterable libs and Node types needed by mixed script + renderer import graphs
    • include renderer ambient declarations so script typecheck sees the same window.roku surface as renderer code
  • Make vendored ESM resolvable in standalone script typecheck

    • add a pretypecheck:scripts hook so typecheck:scripts prepares the generated renderer vendor files before TypeScript runs
    • add a declaration-side companion for renderer/vendor/tanstack-virtual-core.mjs so strict script typecheck can type the vendored ESM import directly
  • Resulting behavior

    • verification scripts that import renderer modules now typecheck in the same environment assumptions as the modules they depend on, instead of failing on config drift
{
  "scripts": {
    "pretypecheck:scripts": "npm run pretypecheck:renderer",
    "typecheck:scripts": "tsc --noEmit -p tsconfig.scripts.json"
  }
}

Co-authored-by: hdonapati <104085142+hdonapati@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix the failing GitHub Actions job Fix Roku Dev Studio script typecheck resolution in CI Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants