Bump vite to ^6.4.3 in test - #26
Merged
Merged
Conversation
Fixes both open security alerts (server.fs.deny bypass on Windows, launch-editor NTLMv2 hash disclosure) within vite 6.x, avoiding the vite 8 major jump that breaks the vite-app integration test. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump vite to ^6.4.3 in
test/.Supersedes #23: both open security alerts (
server.fs.denybypass on Windows, launch-editor NTLMv2 hash disclosure) are patched in vite 6.4.3, so the major jump to vite 8 isn't needed. The vite 8 (rolldown) update in #23 breaks the vite integration test (assets/test.jsis no longer emitted where thepublicDir/externalsetup expects it) — migrating to vite 8 can be a separate PR.Verified locally:
npm ci && npm test— all 4 Playwright tests (web + vite, chromium + firefox) pass with vite 6.4.3.🤖 Generated with Claude Code