[server] restore SMBIOS type 1 input on instance ensure

[zeeshanlakhani]

The instance spec versioning rework in #1178 moved the API-to-internal conversion into per-version SpecBuilder paths, but dropped the assignment of the API spec's smbios field to the internal spec's smbios_type1_input.

As a result, ensure requests with an explicit SMBIOS Type 1 input silently receive Propolis's default Type 1 values (Oxide/OxVM) instead. This breaks consumers of programmable SMBIOS (#977), like voxel and a4x2, where the SMBIOS manufacturer selects a4x2 hardware and the product and serial values identify the sled's configured BaseboardId during bootstrap.

This change preserves smbios in latest_to_spec_builder, the common funnel for the versioned instance-spec conversion paths, and adds a regression test.

[sion42x]

This looks great and I've verified it works right with voxel. Do we plan on updating the falcon pin from February? I've got some other propolis work I'll be making a PR for soon that would depend on this.

[zeeshanlakhani]

This looks great and I've verified it works right with voxel. Do we plan on updating the falcon pin from February? I've got some other propolis work I'll be making a PR for soon that would depend on this.

we should, though not sure what the proper ordering of deps updates should be.

[sion42x]

Confirmed this fixes the regression and will allow falcon to use a current propolis again. Recommend adding this to #1204 for softnpu performance as well.

[zeeshanlakhani]

@iximeow thoughts on this btw?

[sion42x]

@zeeshanlakhani would you be open to SmbiosType1Input growing the remaining SMBIOS Type 1 fields? sku_number and family (and arguably uuid). We may be able to use this for softnpu detection (similar to tofino::get_tofino_from_devinfo()). See oxidecomputer/omicron#11202 for details on where this matters.

[zeeshanlakhani]

@zeeshanlakhani would you be open to SmbiosType1Input growing the remaining SMBIOS Type 1 fields? sku_number and family (and arguably uuid). We may be able to use this for softnpu detection (similar to tofino::get_tofino_from_devinfo()). See oxidecomputer/omicron#11202 for details on where this matters.

That totally makes sense. Want me to add it? Or, do you want to extend this. I'd also like someone working on propolis to take a gander here.