🐛 fix catalogd panic, paste error on mac#2779
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR addresses cross-platform developer workflow issues in operator-controller’s Make-based build/test tooling, improving macOS compatibility and preventing architecture-mismatch binaries from being produced for make run/docker-build flows.
Changes:
- Make
COVERAGE_PKGSgeneration portable by explicitly specifying stdin (paste ... -) so BSDpasteworks on macOS. - Stop hardcoding
GOARCH=amd64forgo-build-linux, allowingGOOS=linuxbuilds to use the host architecture (fixes Apple silicon workflows and avoids running amd64 binaries via Rosetta).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
/approve |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2779 +/- ##
=======================================
Coverage 70.42% 70.42%
=======================================
Files 143 143
Lines 10617 10617
=======================================
Hits 7477 7477
Misses 2579 2579
Partials 561 561
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: perdasilva, rashmigottipati The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
c2f2d89
into
operator-framework:main
Description
This PR fixes two issues, from least- to most-important:
pastetool in linux, mac contexts.pasteon BSD requires an explicit indication of STDIN, whereas linux assumes STDIN if no file is specified. POSIX behavior is to specify-if STDIN is indicated, which works for both platforms.make runand variants use the "linux" build targets, which claim in docs to use native GOARCH but actually hardcode it to amd64. On Apple silicon the cross-compile now results in panics running these cross-compiled binaries using Rosetta (and Apple has stated it is sunsetting support for amd64 binaries on arm64 hardware, so it needs resolving anyway). The GOARCH hardcoding was introduced during the change to helm templating (from kustomize) but appears to have been unnecessary.Reviewer Checklist