Skip to content

🐛 fix catalogd panic, paste error on mac#2779

Merged
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
grokspawn:mac-panic
Jun 24, 2026
Merged

🐛 fix catalogd panic, paste error on mac#2779
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
grokspawn:mac-panic

Conversation

@grokspawn

@grokspawn grokspawn commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Description

This PR fixes two issues, from least- to most-important:

  1. differing syntax for paste tool in linux, mac contexts. paste on BSD requires an explicit indication of STDIN, whereas linux assumes STDIN if no file is specified. POSIX behavior is to specify - if STDIN is indicated, which works for both platforms.
  2. make run and variants use the "linux" build targets, which claim in docs to use native GOARCH but actually hardcode it to amd64. On Apple silicon the cross-compile now results in panics running these cross-compiled binaries using Rosetta (and Apple has stated it is sunsetting support for amd64 binaries on arm64 hardware, so it needs resolving anyway). The GOARCH hardcoding was introduced during the change to helm templating (from kustomize) but appears to have been unnecessary.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Copilot AI review requested due to automatic review settings June 24, 2026 14:27
@openshift-ci openshift-ci Bot requested review from dtfranz and perdasilva June 24, 2026 14:27
@netlify

netlify Bot commented Jun 24, 2026

Copy link
Copy Markdown

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit d432c81
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/6a3be953decd1a0008196619
😎 Deploy Preview https://deploy-preview-2779--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@grokspawn grokspawn changed the title fix catalogd panic, paste error on mac 🐛 fix catalogd panic, paste error on mac Jun 24, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses cross-platform developer workflow issues in operator-controller’s Make-based build/test tooling, improving macOS compatibility and preventing architecture-mismatch binaries from being produced for make run/docker-build flows.

Changes:

  • Make COVERAGE_PKGS generation portable by explicitly specifying stdin (paste ... -) so BSD paste works on macOS.
  • Stop hardcoding GOARCH=amd64 for go-build-linux, allowing GOOS=linux builds to use the host architecture (fixes Apple silicon workflows and avoids running amd64 binaries via Rosetta).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@perdasilva

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2026
@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.42%. Comparing base (7d6a00d) to head (d432c81).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2779   +/-   ##
=======================================
  Coverage   70.42%   70.42%           
=======================================
  Files         143      143           
  Lines       10617    10617           
=======================================
  Hits         7477     7477           
  Misses       2579     2579           
  Partials      561      561           
Flag Coverage Δ
e2e 35.16% <ø> (+0.04%) ⬆️
experimental-e2e 52.45% <ø> (+0.07%) ⬆️
unit 59.48% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pedjak pedjak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2026
@openshift-ci

openshift-ci Bot commented Jun 24, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva, rashmigottipati

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit c2f2d89 into operator-framework:main Jun 24, 2026
26 of 27 checks passed
@grokspawn grokspawn deleted the mac-panic branch June 24, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants