docs(policy): document dynamic value mappings - #385
Conversation
|
Warning Review limit reached
Next review available in: 14 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe PR adds Dynamic Value Mappings documentation and links it from the Policy documentation. It also updates policy specifications with KeyStatus sorting metadata and mapping requirements. ChangesDynamic Value Mappings
KeyStatus sorting specification
Estimated code review effort: 2 (Simple) | ~10 minutes Mergeability Score: ⚪ Minimal · up to This PR documents dynamic value mappings and updates related policy references and specifications. No actionable merge-blocking risk remains beyond normal checks and review. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
📄 Preview deployed to https://opentdf-docs-pr-385.surge.sh |
| - Actions (optionally scoped to Namespaces) | ||
| - Subject Mappings (optionally scoped to Namespaces) | ||
| - Subject Condition Sets (optionally scoped to Namespaces) | ||
| - [Dynamic Value Mappings](/components/policy/dynamic-value-mappings) (optionally scoped to Namespaces) |
There was a problem hiding this comment.
I think we need /docs prepended , or relative
There was a problem hiding this comment.
Using relative paths is best practice
There was a problem hiding this comment.
That would cause a 404 on the PR preview site.
There was a problem hiding this comment.
What we REALLY need is an automated job that will compile and build docs changes and flag on broken links (cc @penadenise ) -- not an immediate blocker obviously
| - Actions (optionally scoped to Namespaces) | ||
| - Subject Mappings (optionally scoped to Namespaces) | ||
| - Subject Condition Sets (optionally scoped to Namespaces) | ||
| - [Dynamic Value Mappings](/components/policy/dynamic-value-mappings) (optionally scoped to Namespaces) |
There was a problem hiding this comment.
Using relative paths is best practice
|
|
||
| ```mermaid | ||
| flowchart LR | ||
| Resource["Resource Attribute Value<br/>.../value/mrn-123"] --> Segment["Value segment<br/>mrn-123"] |
There was a problem hiding this comment.
It doesn't look like this
is rendering in the GH mermaid renderer 🤔
Co-authored-by: Jake Van Vorhis <83739412+jakedoublev@users.noreply.github.com>
Summary
Testing
vale docs/components/policy/dynamic-value-mappings.mdx docs/components/policy/index.mdnpm run check-vendored-yamlnpm run buildSummary by CodeRabbit