Skip to content

OCPBUGS-122255: tests-extension: fix PolarionID:68521 and Polarion:27680 #1376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
perdasilva wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −3
Open

OCPBUGS-122255: tests-extension: fix PolarionID:68521 and Polarion:27680 #1376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e235699
Fix PolarionID:68521 startupProbe failureThreshold assertion
Sep 15, 2026
8a165a0
Fix ClusterPackageExists to treat NotFound as absent, not an error
Sep 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests-extension/test/qe/specs/olmv0_nonallns.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6577,7 +6577,7 @@ var _ = g.Describe("[sig-operator][Jira:OLM] OLMv0 within a namespace", func() {
}
o.Expect(err).NotTo(o.HaveOccurred())
}
olmv0util.NewCheck("expect", exutil.AsAdmin, exutil.WithoutNamespace, exutil.Contain, "10", exutil.Ok, []string{"pods", "-n", "openshift-marketplace", "-l", "olm.catalogSource=redhat-operators", "-o=jsonpath={..spec.containers[0].startupProbe.failureThreshold}"}).Check(oc)
olmv0util.NewCheck("expect", exutil.AsAdmin, exutil.WithoutNamespace, exutil.Contain, "15", exutil.Ok, []string{"pods", "-n", "openshift-marketplace", "-l", "olm.catalogSource=redhat-operators", "-o=jsonpath={..spec.containers[0].startupProbe.failureThreshold}"}).Check(oc)
})

g.It("PolarionID:68901-[OTP][Skipped:Disconnected]Packageserver pod should not crash if updateStrategy is incorrect", g.Label("NonHyperShiftHOST"), func() {
Expand Down
8 changes: 6 additions & 2 deletions tests-extension/test/qe/util/olmv0util/helper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,10 +304,14 @@ func removeResource(oc *exutil.CLI, AsAdmin bool, WithoutNamespace bool, paramet

func ClusterPackageExists(oc *exutil.CLI, sub SubscriptionDescription) (bool, error) {
msg, err := oc.AsAdmin().WithoutNamespace().Run("get").Args("packagemanifest", sub.OperatorPackage, "-n", sub.CatalogSourceNamespace).Output()
if err != nil || strings.Contains(msg, "not found") {
if err != nil {
// A missing packagemanifest is a legitimate "does not exist" result, not a query error.
if strings.Contains(msg, "NotFound") || strings.Contains(msg, "not found") {
return false, nil
}
return false, err
}
return true, err
return true, nil
}

func ClusterPackageExistsInNamespace(oc *exutil.CLI, sub SubscriptionDescription, namespace string) (bool, error) {
Expand Down