Skip to content

OCPBUGS-114428: Bump google.golang.org/protobuf to v1.36.12 - #377

Open
redhat-chai-bot wants to merge 2 commits into
openshift:masterfrom
redhat-chai-bot:bot/ocpbugs-114428-protobuf-v1.36.12
Open

redhat-chai-bot wants to merge 2 commits into
openshift:masterfrom
redhat-chai-bot:bot/ocpbugs-114428-protobuf-v1.36.12

Conversation

@redhat-chai-bot

@redhat-chai-bot redhat-chai-bot commented Sep 14, 2026

Copy link
Copy Markdown

Bump google.golang.org/protobuf to v1.36.12 in the payload dependency module(s). This is a protobuf-only change; required module/vendor metadata is included, with no builder or unrelated changes. Validation completed.


AI-generated. Review for accuracy.

@Prashanth684 requested in Slack thread

Warning

Content scanning did not attest this change.
The scanner could not produce a verdict for the pushed content (never_attempted), so it has not been checked for credentials or malware.
Content scanning currently fails open, so this did not hold the change request for review — please review the diff with that in mind.

Summary by CodeRabbit

  • Chores
    • Updated an underlying dependency to a newer version, bringing compatibility and maintenance improvements.

@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Sep 14, 2026
@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: bc833d1a-678c-4e61-8167-34c33580dc1f

📥 Commits

Reviewing files that changed from the base of the PR and between bb5169e and a4ace94.

⛔ Files ignored due to path filters (47)
  • go.sum is excluded by !**/*.sum
  • vendor/google.golang.org/protobuf/encoding/protodelim/protodelim.go is excluded by !**/vendor/**, !vendor/**
  • vendor/google.golang.org/protobuf/encoding/protojson/decode.go is excluded by !**/vendor/**, !vendor/**
  • vendor/google.golang.org/protobuf/encoding/protojson/well_known_types.go is excluded by !**/vendor/**, !vendor/**
  • vendor/google.golang.org/protobuf/encoding/prototext/decode.go is excluded by !**/vendor/**, !vendor/**
  • vendor/google.golang.org/protobuf/encoding/protowire/wire.go is excluded by !**/vendor/**, !vendor/**
  • vendor/google.golang.org/protobuf/internal/descfmt/stringer.go is excluded by !**/vendor/**, !vendor/**
  • vendor/google.golang.org/protobuf/internal/editiondefaults/editions_defaults.binpb is excluded by !**/vendor/**, !vendor/**
  • vendor/google.golang.org/protobuf/internal/editionssupport/editions.go is excluded by !**/vendor/**, !vendor/**
  • vendor/google.golang.org/protobuf/internal/encoding/defval/default.go is excluded by !**/vendor/**, !vendor/**
  • vendor/google.golang.org/protobuf/internal/encoding/tag/tag.go is excluded by !**/vendor/**, !vendor/**
  • vendor/google.golang.org/protobuf/internal/encoding/text/decode.go is excluded by !**/vendor/**, !vendor/**
  • vendor/google.golang.org/protobuf/internal/filedesc/desc.go is excluded by !**/vendor/**, !vendor/**
  • vendor/google.golang.org/protobuf/internal/filedesc/desc_init.go is excluded by !**/vendor/**, !vendor/**
  • vendor/google.golang.org/protobuf/internal/filedesc/desc_lazy.go is excluded by !**/vendor/**, !vendor/**
  • vendor/google.golang.org/protobuf/internal/filedesc/editions.go is excluded by !**/vendor/**, !vendor/**
  • vendor/google.golang.org/protobuf/internal/filedesc/presence.go is excluded by !**/vendor/**, !vendor/**
  • vendor/google.golang.org/protobuf/internal/genid/api_gen.go is excluded by !**/vendor/**, !vendor/**
  • vendor/google.golang.org/protobuf/internal/genid/descriptor_gen.go is excluded by !**/vendor/**, !vendor/**
  • vendor/google.golang.org/protobuf/internal/impl/codec_map.go is excluded by !**/vendor/**, !vendor/**
  • vendor/google.golang.org/protobuf/internal/impl/codec_message_opaque.go is excluded by !**/vendor/**, !vendor/**
  • vendor/google.golang.org/protobuf/internal/impl/decode.go is excluded by !**/vendor/**, !vendor/**
  • vendor/google.golang.org/protobuf/internal/impl/message_opaque.go is excluded by !**/vendor/**, !vendor/**
  • vendor/google.golang.org/protobuf/internal/impl/presence.go is excluded by !**/vendor/**, !vendor/**
  • vendor/google.golang.org/protobuf/internal/impl/validate.go is excluded by !**/vendor/**, !vendor/**
  • vendor/google.golang.org/protobuf/internal/strs/strings_unsafe.go is excluded by !**/vendor/**, !vendor/**
  • vendor/google.golang.org/protobuf/internal/strs/strings_unsafe_go120.go is excluded by !**/vendor/**, !vendor/**
  • vendor/google.golang.org/protobuf/internal/version/version.go is excluded by !**/vendor/**, !vendor/**
  • vendor/google.golang.org/protobuf/proto/decode.go is excluded by !**/vendor/**, !vendor/**
  • vendor/google.golang.org/protobuf/proto/merge.go is excluded by !**/vendor/**, !vendor/**
  • vendor/google.golang.org/protobuf/reflect/protodesc/desc.go is excluded by !**/vendor/**, !vendor/**
  • vendor/google.golang.org/protobuf/reflect/protodesc/desc_init.go is excluded by !**/vendor/**, !vendor/**
  • vendor/google.golang.org/protobuf/reflect/protodesc/editions.go is excluded by !**/vendor/**, !vendor/**
  • vendor/google.golang.org/protobuf/reflect/protodesc/proto.go is excluded by !**/vendor/**, !vendor/**
  • vendor/google.golang.org/protobuf/reflect/protoreflect/source_gen.go is excluded by !**/vendor/**, !vendor/**
  • vendor/google.golang.org/protobuf/reflect/protoreflect/value_unsafe.go is excluded by !**/vendor/**, !vendor/**
  • vendor/google.golang.org/protobuf/reflect/protoreflect/value_unsafe_go120.go is excluded by !**/vendor/**, !vendor/**
  • vendor/google.golang.org/protobuf/types/descriptorpb/descriptor.pb.go is excluded by !**/*.pb.go, !**/vendor/**, !vendor/**
  • vendor/google.golang.org/protobuf/types/gofeaturespb/go_features.pb.go is excluded by !**/*.pb.go, !**/vendor/**, !vendor/**
  • vendor/google.golang.org/protobuf/types/known/anypb/any.pb.go is excluded by !**/*.pb.go, !**/vendor/**, !vendor/**
  • vendor/google.golang.org/protobuf/types/known/durationpb/duration.pb.go is excluded by !**/*.pb.go, !**/vendor/**, !vendor/**
  • vendor/google.golang.org/protobuf/types/known/emptypb/empty.pb.go is excluded by !**/*.pb.go, !**/vendor/**, !vendor/**
  • vendor/google.golang.org/protobuf/types/known/fieldmaskpb/field_mask.pb.go is excluded by !**/*.pb.go, !**/vendor/**, !vendor/**
  • vendor/google.golang.org/protobuf/types/known/structpb/struct.pb.go is excluded by !**/*.pb.go, !**/vendor/**, !vendor/**
  • vendor/google.golang.org/protobuf/types/known/timestamppb/timestamp.pb.go is excluded by !**/*.pb.go, !**/vendor/**, !vendor/**
  • vendor/google.golang.org/protobuf/types/known/wrapperspb/wrappers.pb.go is excluded by !**/*.pb.go, !**/vendor/**, !vendor/**
  • vendor/modules.txt is excluded by !**/vendor/**, !vendor/**
📒 Files selected for processing (1)
  • go.mod

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


Walkthrough

The pull request updates the indirect google.golang.org/protobuf dependency from v1.36.5 to v1.36.12.

Changes

Dependency update

Layer / File(s) Summary
Update protobuf requirement
go.mod
The indirect google.golang.org/protobuf requirement is updated from v1.36.5 to v1.36.12.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested reviewers: dusk125

Merge Risk: ⚪ Minimal · up to a4ace

This dependency-only update presents no evidenced merge-blocking risk.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the protobuf dependency update and specifies the target version, which matches the main change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS: The review-scoped diff updates google.golang.org/protobuf from v1.36.5 to v1.36.12 in go.mod, go.sum, and vendored protobuf sources. It adds or changes no test files and no Ginkgo title de…
Test Structure And Quality ✅ Passed PASS: The pull request changes go.mod, go.sum, and vendored google.golang.org/protobuf files only. The authoritative diff contains no Ginkgo tests or test files, so the listed test-structure req…
Microshift Test Compatibility ✅ Passed PASS: The authoritative pull-request diff changes only protobuf dependency metadata and vendored protobuf files. It adds no Ginkgo e2e tests or other test declarations, so the MicroShift test compatib…
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS. The authoritative pull-request diff changes only go.mod, go.sum, vendor/modules.txt, and vendored google.golang.org/protobuf files. It adds no Ginkgo e2e tests or other test code, so the SNO mul…
Topology-Aware Scheduling Compatibility ✅ Passed PASS: The pull request changes only Go module metadata and vendored google.golang.org/protobuf files. The authoritative diff contains no deployment manifests, operator code, controllers, or scheduli…
Ote Binary Stdout Contract ✅ Passed The PR changes only dependency metadata and vendored google.golang.org/protobuf code. No main, suite setup, or test framework files changed. Structural searches found no os.Stdout, fmt.Print*,…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The check is not applicable. The PR changes only Go module metadata, checksums, and vendored google.golang.org/protobuf sources. It adds no Ginkgo tests or test files, and no new test networking beh…
No-Weak-Crypto ✅ Passed PASS. The PR updates google.golang.org/protobuf from v1.36.5 to v1.36.12 and refreshes go.sum and vendored protobuf files. The changed Go files add no crypto imports, weak-algorithm markers, ciphe…
Container-Privileges ✅ Passed The pull request changes only Go dependency metadata and vendored google.golang.org/protobuf sources. The authoritative diff contains no container or Kubernetes manifests, and no added lines match `…
No-Sensitive-Data-In-Logs ✅ Passed The PR changes the protobuf dependency metadata and vendored protobuf implementation only. The authoritative diff adds no logger imports or logging calls, and structural searches found no log, slog, z…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Sep 14, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@redhat-chai-bot: This pull request references Jira Issue OCPBUGS-114428, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bump google.golang.org/protobuf to v1.36.12 in the payload dependency module(s). This is a protobuf-only change; required module/vendor metadata is included, with no builder or unrelated changes. Validation completed.


AI-generated. Review for accuracy.

@Prashanth684 requested in Slack thread

[!WARNING]
Content scanning did not attest this change.
The scanner could not produce a verdict for the pushed content (never_attempted), so it has not been checked for credentials or malware.
Content scanning currently fails open, so this did not hold the change request for review — please review the diff with that in mind.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Sep 14, 2026

Copy link
Copy Markdown

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci

openshift-ci Bot commented Sep 14, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: redhat-chai-bot
Once this PR has been reviewed and has the lgtm label, please assign everettraven for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Sep 14, 2026

Copy link
Copy Markdown

@redhat-chai-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images a5b43c4 link true /test images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants