Skip to content

Remove uuid dependency in lib-core and lib-utils - #333

Merged
openshift-merge-bot[bot] merged 4 commits into
openshift:mainfrom
vojtechszocs:bump-uuid
Jul 30, 2026
Merged

Remove uuid dependency in lib-core and lib-utils#333
openshift-merge-bot[bot] merged 4 commits into
openshift:mainfrom
vojtechszocs:bump-uuid

Conversation

@vojtechszocs

@vojtechszocs vojtechszocs commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Summary

Remove uuid dependency in lib-core and lib-utils packages.

uuid method v4 is replaced with crypto.getRandomValues based utility function.

Motivation

uuid has a known security vulnerability CVE-2026-41907 (1) (2) which impacts its v3, v5 and v6 API methods.

Both lib-core and lib-utils packages currently use uuid method v4 only - not impacted by this CVE.

It's best to remove uuid dependency and use standard Crypto API to generate UUID v4 compatible values.

@openshift-ci
openshift-ci Bot requested review from florkbr and karelhala July 29, 2026 19:27
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2026
@vojtechszocs

Copy link
Copy Markdown
Contributor Author

Actually we don't need uuid and can use different methods which would allow us to drop this dependency.

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 29, 2026
@codecov-commenter

codecov-commenter commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 30.91%. Comparing base (c8de7aa) to head (e8f7427).

Files with missing lines Patch % Lines
packages/common/src/index.ts 0.00% 1 Missing ⚠️
packages/lib-core/src/runtime/PluginLoader.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #333      +/-   ##
==========================================
+ Coverage   30.51%   30.91%   +0.40%     
==========================================
  Files          75       76       +1     
  Lines        1973     1986      +13     
  Branches      348      348              
==========================================
+ Hits          602      614      +12     
- Misses       1342     1343       +1     
  Partials       29       29              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vojtechszocs vojtechszocs changed the title Bump uuid dependency in lib-core and lib-utils Remove uuid dependency in lib-core and lib-utils Jul 30, 2026
@vojtechszocs

Copy link
Copy Markdown
Contributor Author

/hold cancel

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 30, 2026

@logonoff logonoff left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2026
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2026
@vojtechszocs
vojtechszocs force-pushed the bump-uuid branch 2 times, most recently from d2f5a07 to df232d3 Compare July 30, 2026 21:12
@openshift-ci

openshift-ci Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

@vojtechszocs: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@logonoff logonoff left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2026
@openshift-ci

openshift-ci Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [logonoff,vojtechszocs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit 28380d9 into openshift:main Jul 30, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants