Skip to content

OCPBUGS-114020: Use branch 5.1 for Konflux builds - #344

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
bfournie:konflux-use-5.1
Aug 26, 2026
Merged

OCPBUGS-114020: Use branch 5.1 for Konflux builds#344
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
bfournie:konflux-use-5.1

Conversation

@bfournie

@bfournie bfournie commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

We are in the process of migrating the Konflux builds to the ART namespace and these .texton files will no longer be maintained. Until then we'll get Konflux build failures since the appliance release is named agent-release-iso-builder in the main branch only, see #333.

This is an attempt to get the Konflux builds to pass for now using a nightly release since we currently don't have any stable releases for 5.1.

Summary by CodeRabbit

  • Chores
    • Updated the OVE UI ISO pull-request pipeline to use the OpenShift 5.1 nightly release image and matching version settings.

We are in the process of migrating the Konflux builds to the ART
namespace and these .texton files will no longer be maintained.
Until then we'll get Konflux build failures since the appliance
release is named agent-release-iso-builder in the main branch
only, see openshift#333.

This is an attempt to get the Konflux builds to pass for now using
a nightly release since we currently don't have any stable releases
for 5.1.
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 25, 2026
@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: a97107e5-84d5-44ab-a47a-022108878abf

📥 Commits

Reviewing files that changed from the base of the PR and between 974f3f6 and 8a909fa.

📒 Files selected for processing (1)
  • .tekton/ove-ui-iso-pull-request.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Walkthrough

The OVE UI ISO pull-request pipeline now uses the OpenShift 5.1 nightly release image and matching version parameters instead of OpenShift 4.22.4 values.

Changes

OVE UI ISO pipeline

Layer / File(s) Summary
Update pipeline release version
.tekton/ove-ui-iso-pull-request.yaml
The pipeline now uses the OpenShift 5.1 nightly release image, major/minor version 5.1, and patch version 0.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 8a909

This is a localized build-configuration change, and no actionable merge-blocking risk remains in the supplied evidence beyond normal checks and owner review.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS. The pull request changes only .tekton/ove-ui-iso-pull-request.yaml. The three changes update the release image and version parameters. The diff contains no Ginkgo test files or test-title cons…
Test Structure And Quality ✅ Passed PASS: The pull request changes only .tekton/ove-ui-iso-pull-request.yaml. The diff updates release image and version parameters; it does not add or modify Ginkgo tests, It blocks, setup/cleanup, w…
Microshift Test Compatibility ✅ Passed PASS: The pull request changes only .tekton/ove-ui-iso-pull-request.yaml. It updates release image and version parameters. It adds no Ginkgo e2e tests, so the MicroShift test compatibility check is …
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS — The pull request changes only .tekton/ove-ui-iso-pull-request.yaml, replacing release image and version parameters. The diff adds no Ginkgo e2e tests or test paths, so the SNO compatibility c…
Topology-Aware Scheduling Compatibility ✅ Passed PASS: The PR changes only .tekton/ove-ui-iso-pull-request.yaml, a Tekton PipelineRun. The exact diff changes only the release image and version parameters. It adds no deployment, operator, control…
Ote Binary Stdout Contract ✅ Passed PASS: The pull request changes only .tekton/ove-ui-iso-pull-request.yaml. It updates release image and version parameters from 4.22.4 to 5.1. No Go source, OTE binary entry point, suite setup, or st…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS: The pull request changes only .tekton/ove-ui-iso-pull-request.yaml. The committed diff changes release-image and version parameters; it adds no Ginkgo or e2e tests and introduces no test netwo…
No-Weak-Crypto ✅ Passed PASS: The PR changes only the release image reference and version parameters in .tekton/ove-ui-iso-pull-request.yaml. The added values contain no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, custom cry…
Container-Privileges ✅ Passed PASS: The pull request changes only the release image and version parameters in .tekton/ove-ui-iso-pull-request.yaml. The existing privileged-nested: 'true' parameter is unchanged, and the diff in…
No-Sensitive-Data-In-Logs ✅ Passed PASS. The pull request changes only three ISO build parameters: the OpenShift release image and version values. It adds no logging statements, log configuration, credentials, tokens, API keys, PII, se…
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly states the main change: updating Konflux builds to use the 5.1 branch. It is concise and directly matches the configuration changes.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Full details: Stable And Deterministic Test Names

Explanation

PASS. The pull request changes only .tekton/ove-ui-iso-pull-request.yaml. The three changes update the release image and version parameters. The diff contains no Ginkgo test files or test-title constructs such as It(), Describe(), Context(), or When(). Therefore, the custom check is not applicable.

Full details: Test Structure And Quality

Explanation

PASS: The pull request changes only .tekton/ove-ui-iso-pull-request.yaml. The diff updates release image and version parameters; it does not add or modify Ginkgo tests, It blocks, setup/cleanup, waits, or assertions. The Test Structure and Quality check is therefore not applicable.

Full details: Microshift Test Compatibility

Explanation

PASS: The pull request changes only .tekton/ove-ui-iso-pull-request.yaml. It updates release image and version parameters. It adds no Ginkgo e2e tests, so the MicroShift test compatibility check is not applicable.

Full details: Single Node Openshift (Sno) Test Compatibility

Explanation

PASS — The pull request changes only .tekton/ove-ui-iso-pull-request.yaml, replacing release image and version parameters. The diff adds no Ginkgo e2e tests or test paths, so the SNO compatibility check is not applicable.

Full details: Topology-Aware Scheduling Compatibility

Explanation

PASS: The PR changes only .tekton/ove-ui-iso-pull-request.yaml, a Tekton PipelineRun. The exact diff changes only the release image and version parameters. It adds no deployment, operator, controller, replica, affinity, topology spread, node selector, toleration, or PDB scheduling configuration.

Full details: Ote Binary Stdout Contract

Explanation

PASS: The pull request changes only .tekton/ove-ui-iso-pull-request.yaml. It updates release image and version parameters from 4.22.4 to 5.1. No Go source, OTE binary entry point, suite setup, or stdout write changed. The custom check has no applicable failure condition.

Full details: Ipv6 And Disconnected Network Test Compatibility

Explanation

PASS: The pull request changes only .tekton/ove-ui-iso-pull-request.yaml. The committed diff changes release-image and version parameters; it adds no Ginkgo or e2e tests and introduces no test networking behavior. The custom check is therefore not applicable.

Full details: No-Weak-Crypto

Explanation

PASS: The PR changes only the release image reference and version parameters in .tekton/ove-ui-iso-pull-request.yaml. The added values contain no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, custom crypto, or secret/token comparison logic. Existing SHA-256-pinned task images and secret references are unchanged.

Full details: Container-Privileges

Explanation

PASS: The pull request changes only the release image and version parameters in .tekton/ove-ui-iso-pull-request.yaml. The existing privileged-nested: 'true' parameter is unchanged, and the diff introduces no privileged: true, host namespace settings, SYS_ADMIN, allowPrivilegeEscalation: true, or root security settings.

Full details: No-Sensitive-Data-In-Logs

Explanation

PASS. The pull request changes only three ISO build parameters: the OpenShift release image and version values. It adds no logging statements, log configuration, credentials, tokens, API keys, PII, session IDs, or customer data. The existing builder message logs the supplied release image, but the new value is a public CI image reference already present in the repository, not sensitive data.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from celebdor and zaneb August 25, 2026 17:07
@openshift-ci

openshift-ci Bot commented Aug 25, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bfournie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2026
@bfournie

Copy link
Copy Markdown
Contributor Author

/retest

1 similar comment
@bfournie

Copy link
Copy Markdown
Contributor Author

/retest

@zaneb

zaneb commented Aug 26, 2026

Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-agent-bad-dns
/test e2e-agent-compact-ipv4

@bfournie bfournie changed the title WIP: Use branch 5.1 for Konflux builds Use branch 5.1 for Konflux builds Aug 26, 2026
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 26, 2026
@bfournie

Copy link
Copy Markdown
Contributor Author

/verified by "Konflux kflux-prd-rh02 / ove-ui-iso-on-pull-request"

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Aug 26, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@bfournie: This PR has been marked as verified by "Konflux kflux-prd-rh02 / ove-ui-iso-on-pull-request".

Details

In response to this:

/verified by "Konflux kflux-prd-rh02 / ove-ui-iso-on-pull-request"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bfournie bfournie changed the title Use branch 5.1 for Konflux builds OCPBUGS-114020: Use branch 5.1 for Konflux builds Aug 26, 2026
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Aug 26, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@bfournie: This pull request references Jira Issue OCPBUGS-114020, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.1.0) matches configured target version for branch (5.1.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

We are in the process of migrating the Konflux builds to the ART namespace and these .texton files will no longer be maintained. Until then we'll get Konflux build failures since the appliance release is named agent-release-iso-builder in the main branch only, see #333.

This is an attempt to get the Konflux builds to pass for now using a nightly release since we currently don't have any stable releases for 5.1.

Summary by CodeRabbit

  • Chores
  • Updated the OVE UI ISO pull-request pipeline to use the OpenShift 5.1 nightly release image and matching version settings.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bfournie

Copy link
Copy Markdown
Contributor Author

/jira refresh

@openshift-ci-robot

Copy link
Copy Markdown

@bfournie: This pull request references Jira Issue OCPBUGS-114020, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.1.0) matches configured target version for branch (5.1.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bfournie

Copy link
Copy Markdown
Contributor Author

/retest-required

@openshift-ci

openshift-ci Bot commented Aug 26, 2026

Copy link
Copy Markdown

@bfournie: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 36c7e79 into openshift:main Aug 26, 2026
13 checks passed
@openshift-ci-robot

Copy link
Copy Markdown

@bfournie: Jira Issue Verification Checks: Jira Issue OCPBUGS-114020
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-114020 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

We are in the process of migrating the Konflux builds to the ART namespace and these .texton files will no longer be maintained. Until then we'll get Konflux build failures since the appliance release is named agent-release-iso-builder in the main branch only, see #333.

This is an attempt to get the Konflux builds to pass for now using a nightly release since we currently don't have any stable releases for 5.1.

Summary by CodeRabbit

  • Chores
  • Updated the OVE UI ISO pull-request pipeline to use the OpenShift 5.1 nightly release image and matching version settings.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bfournie
bfournie deleted the konflux-use-5.1 branch August 26, 2026 14:09
@openshift-merge-robot

Copy link
Copy Markdown
Contributor

Fix included in release 5.1.0-0.nightly-2026-08-27-012048

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants