fix(ModuleUtils): Safeguard setMDCAdapter call for logback-android compatibility - #356
Open
CoreyAllenAudio wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ModuleUtils.createModuleLogger()throwsNoSuchMethodErroron Android, which killsmodule init — the ConSys client module fails to start on every app launch.
osh-core compiles against logback-classic 1.5.13, which added
LoggerContext.setMDCAdapter()(0c56710). Android builds exclude real Logback andsubstitute logback-android 3.0.0, built from the Logback 1.4.x generation, where that
method doesn't exist. Desktop nodes are unaffected.
Wraps the call in a
NoSuchMethodErrorguard. Logback wired MDC globally before 1.5, soskipping it restores the earlier behavior rather than dropping functionality. The guard
can be removed once logback-android ships a 1.5-based release.
Verified on an Android emulator: system registers and streams datastreams to a node.
kalynstricklin/osh-core#5 has already been reviewed and merged downstream.