Add Swift-specific argument label for resumeExternalUserAgentFlow#966
Merged
Conversation
brnnmrls
reviewed
Jul 23, 2026
brnnmrls
approved these changes
Jul 23, 2026
brnnmrls
left a comment
brnnmrls
left a comment
Collaborator
There was a problem hiding this comment.
LGTM but we should probably open an issue to switch this method to 'required' after allowing clients to migrate. Can we open a new issue or internal tracking bug?
Collaborator
Author
|
Added issue #967 to track the future change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #964. Because there's a naming collision between the old & new methods, the NSError**-to-throws special-casing doesn't complete, leaving the real type lost in the
Void. Which is to say, we were (unfortunately) successful in preserving backwards-compatibility, as the sample app only emitted a warning that the old method was being called. This PR also updates the call in the sample app to ensure this new signature is compiled correctly.