chore: Upgrade Python requirements - #283
Merged
Merged
Conversation
Contributor
Author
|
List of packages in the PR without any issue.
|
… 153 In Firefox 153, video.play() on an element without a real video source no longer fires the 'play' DOM event synchronously or reliably in a headless test environment. The test was using callThrough() which delegated to the real implementation, causing the jasmine.waitUntil() poll to time out before the player state changed from PAUSED. Replace callThrough() with callFake() that manually fires the 'play' event and returns a resolved Promise, matching the real API contract while making the test deterministic in headless browsers. The same fix is applied to the [pause] describe block's beforeEach, which also relies on playVideo() working to transition out of UNSTARTED. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The async waitUntil polling in the [play] tests introduced a 50ms window during which the browser could fire a real loadedmetadata event, resetting playerState back to PAUSED and causing the tests to time out. Since jasmine.fireEvent uses dispatchEvent (synchronous), the state is already BUFFERING when the it callback runs, so the assertions can be made synchronously. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
farhan
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python requirements update. Please review the changelogs for the upgraded packages.