Conversation
This makes sure that the token does not expire if the indexing process takes longer than the token lifetime. This commit also makes sure that the authenticated context is reused instead of generating a new context for each resource which is much more efficient.
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| Security | 2 critical |
🟢 Metrics 17 complexity
Metric Results Complexity 17
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
rhafer
requested changes
Sep 17, 2026
| rpcv1beta1 "github.com/cs3org/go-cs3apis/cs3/rpc/v1beta1" | ||
| collaborationv1beta1 "github.com/cs3org/go-cs3apis/cs3/sharing/collaboration/v1beta1" | ||
| provider "github.com/cs3org/go-cs3apis/cs3/storage/provider/v1beta1" | ||
| "github.com/golang-jwt/jwt/v4" |
Member
There was a problem hiding this comment.
Can we use jwt/v5 here? I know we're also still bundling v4 but just because of transient dependencies.
| return time.Time{}, errors.New("no auth token in context") | ||
| } | ||
| var claims jwt.RegisteredClaims | ||
| if _, _, err := jwt.NewParser().ParseUnverified(tkn, &claims); err != nil { |
Member
There was a problem hiding this comment.
The unit tests use authtoken as the token value. Which will cause an error here. I guess the test need to generate a valid JWT now?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes sure that the token does not expire if the indexing process takes longer than the token lifetime.
This commit also makes sure that the authenticated context is reused instead of generating a new context for each resource which is much more efficient.
Note: Depends on opencloud-eu/reva#804