fix: restore mandatory default admin password change - #873
Merged
Conversation
RussH
enabled auto-merge (squash)
September 12, 2026 10:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore the mandatory password-change flow when the default
admin / catscredentials are used.This is a compatibility-focused fix for the regression identified in #868. It keeps the existing fresh-install credentials for now, but prevents them from remaining usable after the administrator's first login.
Changes
m=settings&a=newInstallPasswordwhenadmin / catsis useddefaultLogin()auto-login behaviour?defaultlogin=truecatspassword is temporaryUsers::resetPassword()path for the password changeRationale
The older JavaScript first-login wizard remains disabled. Restoring it would reintroduce legacy JavaScript and duplicate password-change behaviour which is already available through the existing server-side
newInstallPasswordflow.This deliberately avoids changing the schema, password hashing implementation, upgrade behaviour or existing installation credentials.
Testing
test/features/login.feature: 7/7 scenarios passmoduleSubPagesSecurity.featureshowHideSingleQuickActionMenuassertion; none of the affected candidate/security files differ frommasterSecurity note
Fresh installations still initially use the known
admin / catscredentials, so there remains a window between installation and the legitimate administrator's first login.This change restores the historical mandatory first-login password change as a low-risk compatibility fix. A future installer change can eliminate the shared initial credential entirely.
Refs #868