Conversation
Signed-off-by: 1fanwang <1fannnw@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After changing directories, a SQLite session created with a relative filename can read or clear another database, or raise
sqlite3.OperationalError: no such table: agent_messages.Bind the filename at construction. In-memory sessions and literal
~filenames keep their behavior.Test plan
Ran this against both versions with real SQLite files.
Reproducer and raw logs
Before:
After:
The full check has one unrelated docs-publisher failure on both versions: Git's
safe.bareRepository=explicitrejects its bare-repo fixture. The SQLite and serial tests pass.Issue number
No issue filed.
Checks
.agents/skills/code-change-verification/scripts/run.sh/reviewbefore submitting this PR (Not applicable.)