Conversation
szysas
marked this pull request as ready for review
September 2, 2026 07:58
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #150 +/- ##
============================================
+ Coverage 92.86% 92.92% +0.06%
- Complexity 2141 2142 +1
============================================
Files 135 135
Lines 4762 4761 -1
Branches 637 637
============================================
+ Hits 4422 4424 +2
+ Misses 194 192 -2
+ Partials 146 145 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pmddependencies inbuild.gradle.ktsso Dependabot automatically tracks future PMD updates, isolated into separate PRs via.github/dependabot.yml.pmd-rules.xmlfor PMD 7 compatibility and disables PMD on the deprecatedlwm2mmodule.PMD Rules Fixed in Code
LooseCoupling: Switched from concrete types (ArrayList,LinkedList,ConcurrentHashMap) to interfaces (List,ConcurrentMap,Map).EnumComparison: Replaced.equals()with==on enum comparisons.ModifierOrder: Standardized Java modifier order (e.g.public static final).UnusedReturnValue: Replaced uncheckedInputStream.read()withFiles.readAllBytes().UnnecessaryFullyQualifiedName: Removed redundant class qualifiers already in scope.ImplicitFunctionalInterface: Added@FunctionalInterfaceannotations to SAM interfaces.UnnecessaryBoxing: Removed explicitlongValue()conversions where automatic unboxing/overloads apply.InsufficientStringBufferDeclaration&ConsecutiveAppendsShouldReuse: SizedStringBuildercapacity appropriately and chained.append()calls.UseDiamondOperator&UselessParentheses: Cleaned up diamond syntax and redundant parentheses.Rules Excluded in
pmd-rules.xmlSimplifyBooleanReturns,SimplifyConditional,LiteralsFirstInComparisons,AvoidDeeplyNestedIfStmts,ExceptionAsFlowControl,AvoidSynchronizedStatement).InstantiableUtilityClass,TypeParameterNamingConventions,PublicMemberInNonPublicType,BooleanGetMethodName).