fix: add expand=providers query param and providers field for getDevice - #1710
Open
prachi-okta wants to merge 1 commit into
Open
prachi-okta wants to merge 1 commit into
prachi-okta wants to merge 1 commit into
Conversation
…ce (OKTA-1273483) The getDevice operation was missing the expand query parameter, so provider data could never be requested even though the real Devices API supports expand=providers via DeviceIdentityFacadeV1.getDevice. Adds the expand query parameter (enum: providers) to the getDevice operation and a providers property on the Device schema, backed by a new DeviceProviderInfo schema (provider, payloadVersion, payload). Co-Authored-By: Claude Code
aniket-okta
self-requested a review
September 17, 2026 06:12
aniket-okta
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getDevicewas missing theexpandquery parameter, soexpand=providerscould never be sent even though the real Devices API supports it viaDeviceIdentityFacadeV1.getDevice.expandquery parameter (enum: [providers], the only value with real effect on this endpoint) to thegetDeviceoperation insrc/swagger/api.yaml.providersproperty to theDeviceschema, backed by a newDeviceProviderInfoschema (provider,payloadVersion,payload) matching the internalDeviceProviderInfoDTO shape.Jira: OKTA-1273483
Test plan
mvnw -pl api,impl -am generate-sources/compile— build succeeds; generator error count unchanged from baseline (pre-existing, unrelated$refwarnings)DeviceApi.getDevice(String deviceId, String expand, ...)now passesexpandas a query parameterDevice.javanow has aprovidersfield of typeList<DeviceProviderInfo>, andDeviceProviderInfo.javawas generated withprovider/payloadVersion/payloadAI Attribution:
ai-agent-authored