Skip to content

Updated flake.nix to work instead of breaking - #3757

Open
caveman210 wants to merge 2 commits into
ohcnetwork:developfrom
caveman210:develop
Open

caveman210 wants to merge 2 commits into
ohcnetwork:developfrom
caveman210:develop

Conversation

@caveman210

@caveman210 caveman210 commented Sep 13, 2026

Copy link
Copy Markdown

Proposed Changes

  • Edited flake.nix to not fall into an infinite recursion error loop

Associated Issue

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@ohcnetwork/care-backend-maintainers @ohcnetwork/care-backend-admins

Summary by CodeRabbit

  • Chores
    • Updated Linux process-management command resolution for improved consistency in Nix-based environments.
    • Preserved existing behavior on Darwin systems.
    • No changes were made to exported interfaces or user-facing functionality.

@caveman210
caveman210 requested a review from a team as a code owner September 13, 2026 18:49
@coderabbitai

coderabbitai Bot commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: ece5a375-fdea-4524-aa62-b0cc80e5be90

📥 Commits

Reviewing files that changed from the base of the PR and between a749b92 and 212b5e0.

📒 Files selected for processing (1)
  • flake.nix

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

Changes

Process command resolution

Layer / File(s) Summary
Linux command path correction
flake.nix
Linux pgrep and pkill now use ${pkgs.procps}/bin/pgrep and ${pkgs.procps}/bin/pkill. Darwin continues to use /usr/bin/pgrep and /usr/bin/pkill.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: vigneshhari

Merge Risk: ⚪ Minimal · up to 7b7f1

The flake now uses explicit Linux procps command paths without changing Darwin behavior, so it is ready to merge.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title identifies flake.nix but uses vague wording and does not state that the change prevents an infinite recursion error. Use a specific title such as "Fix infinite recursion in flake.nix process command paths".
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The description includes the proposed change, associated issue, and merge checklist. It is sufficiently complete for this small configuration change, although the test and lint checklist items remain …
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@tellmeY18

Copy link
Copy Markdown
Member

Do an end to end test on your linux machine to verify all the other devshell commands are also functioning as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants