fix(volume): restore volume for the same bindings dial controls - #156
Closed
madebynoxc wants to merge 1 commit into
Closed
fix(volume): restore volume for the same bindings dial controls#156madebynoxc wants to merge 1 commit into
madebynoxc wants to merge 1 commit into
Conversation
Owner
|
I'm currently not booted into Linux, so haven't been able to validate it completely, but it looked like it should work. I've made Claude move the match rule into one place so the dial and restore paths can't drift apart again, which also covers portal app ids and the same mismatch on the focus-volume path. They added a CHANGELOG entry too. The pull request doesn't show that it's merged due to the cherry pick, but the work is in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linux-specific issue.
LinuxNewSessionVolumeServicedecided whether a new or changed audio session belonged to an App-volume binding with an exact, case-sensitiveList.containsagainst the stream's executable name only, but the command that drives the dial matches the executable or the title, case-insensitively. So what matched the binding, didn't match the volume restore. This PR adds a more fuzzy match to have the same logic as binding.I did the fix, Claude did the investigation, authored a test for this change and ran the tests for me.