Fix SIGHUP - #4113
Merged
Merged
Conversation
End-rey
requested review from
carpawell,
cthulhu-rider and
roman-khimov
as code owners
July 31, 2026 15:45
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4113 +/- ##
==========================================
- Coverage 27.19% 27.18% -0.01%
==========================================
Files 677 677
Lines 46206 46210 +4
==========================================
- Hits 12564 12562 -2
- Misses 32442 32447 +5
- Partials 1200 1201 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
roman-khimov
left a comment
roman-khimov
left a comment
Member
There was a problem hiding this comment.
Create an issue for neofs-testcases to test these scenarios.
carpawell
reviewed
Aug 4, 2026
roman-khimov
left a comment
roman-khimov
left a comment
Member
There was a problem hiding this comment.
Create an issue for neofs-testcases to test these scenarios.
End-rey
force-pushed
the
fix-sighup
branch
2 times, most recently
from
August 10, 2026 17:08
8848cd1 to
771b309
Compare
Validate the newly read configuration before applying it. Invalid configuration now aborts reload before services are modified. Stop the node when configuration reload fails, preventing it from running with a runtime state that can differ from the configuration file or environment. Systemd restarts the node according to the service restart policy. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
Handle node attribute parsing errors through the common graceful shutdown path. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
Contributor
Author
|
The gRPC-specific fixes no longer make sense because any SIGHUP reload failure now triggers a graceful node shutdown. |
roman-khimov
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed some issues when adding a new configuration to gRPC.