sync experiment by UlisesGascon · Pull Request #5 · nodesource/pyroscope

UlisesGascon · 2025-08-12T21:14:01Z

NO MERGE.

This PR just includes all the changes that we don't have from the original repo for an easier review. cc: @JungMinu @juanarbol

My 2cents so far:

I didn't saw any "fix" commit related to levels or names. So I assume that this bug is only happen in our fork?

They are failing since some time and we are planning to migrate to ebpf-profiler from open-telemetry.

Just to see if I understood it well :)

…ation value (#4023)

* chore: Update otel to latest versions This carries a lot of other upgrade to dependcies along with it. It tried to sync all the code generation versions in Makefile with the updated go modules in go.mod. I also had to switch the minimum version in go.mod from 1.22 to 1.22.0 (because that's what otel does). * Handle empty location index * Remove tool chains * And another one

Co-authored-by: Pyroscope Bot <dmitry+bot@pyroscope.io>

* chore: bump to go1.23 & address CVE-2025-22868

* cypress: test check * bump cypress to 13.0.0 * Revert "cypress: test check" This reverts commit 54cf8a7.

) * go get golang.org/x/net@v0.36.0 and go mod tidy on go.mod * go get golang.org/x/net@v0.36.0 and go mod tidy on ebpf/go.mod * go get golang.org/x/net@v0.36.0 and go mod tidy on api/go.mod

…4039) Bumps [github.com/golang-jwt/jwt/v5](https://github.com/golang-jwt/jwt) from 5.2.1 to 5.2.2. - [Release notes](https://github.com/golang-jwt/jwt/releases) - [Changelog](https://github.com/golang-jwt/jwt/blob/main/VERSION_HISTORY.md) - [Commits](golang-jwt/jwt@v5.2.1...v5.2.2) --- updated-dependencies: - dependency-name: github.com/golang-jwt/jwt/v5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Use default size constant for initializing tree in benchmark Refactor the benchmark for `*stacktraceTree.insert` to use the constant for default tree size instead of hard-coding 0. This will become useful in future changes. * Add benchmark for `*stacktraceTree.insert` with different init sizes This benchmark can be slow, thus it won't run unless the `COMPARE_STACKTRACETREE_INSERT_DEFAULT_SIZES` environment variable is set to true. In addition, if the `-v` flag is passed to `go test` it will print the initial and max tree size after inserting all the samples from the test profile. * Remove commented out line * Always run stacktraceTree default size benchmark * Use b.ReportMetric instead of b.Log We could revisit if we want to always show these values, and if we want to add/remove columns.

Co-authored-by: Pyroscope Bot <dmitry+bot@pyroscope.io>

In the error case the time window might already have been removed by the time the aggreagtion after the first error occours. I ammended the test, that it accepts either outcome of the following aggreagtions. But it also makes sure the aggreagtion eventually recovers.

Our validation has been overly strict, since inception of the project. Although we failed to call the validate alltogether. This was fixed in This PR loosens the criteria accordingly Fixes #3968

* chore(deps): bump @babel/runtime from 7.22.6 to 7.26.10 Bumps [@babel/runtime](https://github.com/babel/babel/tree/HEAD/packages/babel-runtime) from 7.22.6 to 7.26.10. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.26.10/packages/babel-runtime) --- updated-dependencies: - dependency-name: "@babel/runtime" dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * Update to nodejs v20 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Christian Simon <simon@swine.de>

* feat: Align missing service_name behaviour with otel spec When looking at otel-ebpf-profiler I noticed we ignored their specification: https://github.com/open-telemetry/opentelemetry-go/blob/ecfb73581f1b05af85fc393c3ce996a90cf2a5e2/semconv/v1.30.0/attribute_group.go#L10011-L10025 * Fix integration test * More integration * Make more use of constants

* chore: Update @pyroscope/node-js * Fix teardown

* feat: Add Prometheus to the rideshare demo w/utf_8 (#4011) --------- Co-authored-by: Marc Mignonsin <marc.mignonsin@grafana.com> Co-authored-by: Christian Simon <simon@swine.de> Co-authored-by: pyroscope-development-app[bot] <191832211+pyroscope-development-app[bot]@users.noreply.github.com> Co-authored-by: Pyroscope Bot <dmitry+bot@pyroscope.io>

Co-authored-by: Pyroscope Bot <dmitry+bot@pyroscope.io>

Not too sure what those packages do, but hopefully they still compile/work :)

* fix: Update minio-go to fix bug in AWS STS auth With the upgrade of objstore libraries from #3954 we introduced bug This fixes the underlying problem and adds a tests to validate that form of auth. * lint * Be more specific about the format

…na (#4292) * fix: make ingress PathType configurable via `values.yaml` * Run code generate `make helm/check helm/docs` --------- Co-authored-by: Christian Simon <simon@swine.de>

Co-authored-by: Pyroscope Bot <dmitry+bot@pyroscope.io>

When the cookie contains valid base64 in json, with an empty token field. We return a nil token and eat the innerError, which leads to nil pointer exception down the line.

This was added to store Alloy config related to Profile collection. These settings were only stored there for a very brief moment and no main commit or released version of the Profiles Drilldown app every relied on it. This clears up everything and will leave no trace. This is okay as the feature was marked as experimental

* Add frame pointers needed for additional ebpf langs * Make ebpf supported languages content shared and in new places

The use of oauth2-proxy just for nonce handling is total overkill. Given there is a critical vulnerablility in oauth2-proxy, that will be flagged I rather remove it at this point.

* Improve distributor sampling rule evaluation * Improve wording * Switch to strings.Contains and add test

…4352) * Add doc for finding URL, pw, user in Cloud Profiles * Apply suggestions from code review Co-authored-by: Bryan Huhta <32787160+bryanhuhta@users.noreply.github.com> --------- Co-authored-by: Bryan Huhta <32787160+bryanhuhta@users.noreply.github.com>

* chore: Update cypress to latest version * Set the locale for cypress * Locale messing about * Now with sudo * more tries * clean up

Added section describing pyperf error when Python libraries have custom names

* fix broken pprof split when using relabel.LabelDrop * Add benchmark * Add test

Bumps [tmp](https://github.com/raszi/node-tmp) from 0.2.1 to 0.2.4. - [Changelog](https://github.com/raszi/node-tmp/blob/master/CHANGELOG.md) - [Commits](raszi/node-tmp@v0.2.1...v0.2.4) --- updated-dependencies: - dependency-name: tmp dependency-version: 0.2.4 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update setup-linux.md * Update docs/sources/configure-client/grafana-alloy/ebpf/setup-linux.md * Update setup-linux.md Change refs to links. --------- Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>

coderabbitai · 2025-08-12T21:14:09Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

Visit our Status Page to check the current availability of CodeRabbit.
Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

* feat: annotate sampled profiles * Update pkg/distributor/annotation/throttling.go Co-authored-by: Tolya Korniltsev <korniltsev.anatoly@gmail.com> --------- Co-authored-by: Tolya Korniltsev <korniltsev.anatoly@gmail.com>

kolesnikovae and others added 30 commits March 19, 2025 11:59

chore: add optional shutdown delay (#4014)

28e1d6c

chore: Remove qemu ebpf tests (#4019)

b5b546a

They are failing since some time and we are planning to migrate to ebpf-profiler from open-telemetry.

Update receive_profiles.md (#4001)

5dc9fe7

Just to see if I understood it well :)

fix pyroscope.java kubernetes example (#4022)

3f4c1fb

doc: fix configure-disk-storage.md default -pyroscopedb.max-block-dur…

69fc349

…ation value (#4023)

chore(examples): update examples (#4032)

1c81971

Co-authored-by: Pyroscope Bot <dmitry+bot@pyroscope.io>

chore: address CVE-2024-53382 (#4031)

3ee8eec

chore: bump to go1.23 & address CVE-2025-22868 (#4030)

c8ff765

* chore: bump to go1.23 & address CVE-2025-22868

bump cypress to 13.0.0 (#4034)

094a383

* cypress: test check * bump cypress to 13.0.0 * Revert "cypress: test check" This reverts commit 54cf8a7.

chore: bump golang.org/x/net to v0.36.0 to address CVE-2025-22870 (#4035

85ba9a4

) * go get golang.org/x/net@v0.36.0 and go mod tidy on go.mod * go get golang.org/x/net@v0.36.0 and go mod tidy on ebpf/go.mod * go get golang.org/x/net@v0.36.0 and go mod tidy on api/go.mod

docs: updates the list of contributors in README

56f1fd2

fix(v2): disable parquet page index (#4036)

e8f4d85

docs: Add v1.13 release notes (#4040)

3460183

chore: bump helm chart to v1.13.0 (#4041)

8d83761

chore(examples): update examples (#4043)

bd5490a

Co-authored-by: Pyroscope Bot <dmitry+bot@pyroscope.io>

fix: Storage prefix validation (#4044)

ed11e4a

Our validation has been overly strict, since inception of the project. Although we failed to call the validate alltogether. This was fixed in This PR loosens the criteria accordingly Fixes #3968

feat(v2): X-Scope-OrgId in exporter headers (#4046)

40ef27c

chore: Upgrade prismjs in old frontend (#4053)

06df61f

chore: Update @pyroscope/node-js (#4049)

93c7955

* chore: Update @pyroscope/node-js * Fix teardown

chore(examples): update examples (#4055)

664cc9d

Co-authored-by: Pyroscope Bot <dmitry+bot@pyroscope.io>

chore: Update esbuild, micromatch and @babel/helpers (#4054)

cd85f97

Not too sure what those packages do, but hopefully they still compile/work :)

feat(v2): metastore snapshot compression (#4052)

3e66b72

dowster and others added 19 commits July 29, 2025 16:18

fix: change settings.v1.SettingsService pathType to work with grafa…

e6cf49a

…na (#4292) * fix: make ingress PathType configurable via `values.yaml` * Run code generate `make helm/check helm/docs` --------- Co-authored-by: Christian Simon <simon@swine.de>

chore(examples): update examples (#4330)

f9c4f2c

Co-authored-by: Pyroscope Bot <dmitry+bot@pyroscope.io>

fix: vcs.decodeToken can eat an error (#4336)

fdb8dc7

When the cookie contains valid base64 in json, with an empty token field. We return a nil token and eat the innerError, which leads to nil pointer exception down the line.

chore: Reactivate backport workflow action (#4343)

21b137e

docs: Update ebpf supported languages content (#4338)

c615871

* Add frame pointers needed for additional ebpf langs * Make ebpf supported languages content shared and in new places

docs: Update architecture and os requirements for .NET (#4334)

0380053

chore: Remove oauth2-proxy (#4345)

21136ba

The use of oauth2-proxy just for nonce handling is total overkill. Given there is a critical vulnerablility in oauth2-proxy, that will be flagged I rather remove it at this point.

Improve distributor sampling rule evaluation (#4347)

0b02657

* Improve distributor sampling rule evaluation * Improve wording * Switch to strings.Contains and add test

chore: Update cypress to latest version (#4346)

d41599a

* chore: Update cypress to latest version * Set the locale for cypress * Locale messing about * Now with sudo * more tries * clean up

otel: use server.Config grpc server options (#4358)

9ea9ad3

Update troubleshooting.md (#4364)

502d716

Added section describing pyperf error when Python libraries have custom names

distributor: single profile series processing (#4342)

10710fc

chore: Improve tracing visibility into distributor (#4361)

c2e798e

fix issue in pprof split when using relabel.LabelDrop (#4365)

76a7e73

* fix broken pprof split when using relabel.LabelDrop * Add benchmark * Add test

distributor: add new metrics (#4367)

f57601a

UlisesGascon self-assigned this Aug 12, 2025

AntoxaBarin and others added 8 commits August 13, 2025 10:42

Add missing bracket in profile-cli.md (#4369)

c9dd613

Update supported-languages-ebpf.md (#4363)

1a30550

feat: Set querier.max-flamegraph-nodes-max default to 1,048,576 (#4370)

0360777

Update kubernetes.go (#4371)

a500e5a

docs: fix typo and update link for GitHub integration (#4374)

d156d74

feat: annotate sampled profiles (#4375)

214733c

* feat: annotate sampled profiles * Update pkg/distributor/annotation/throttling.go Co-authored-by: Tolya Korniltsev <korniltsev.anatoly@gmail.com> --------- Co-authored-by: Tolya Korniltsev <korniltsev.anatoly@gmail.com>

feat(distributor): sample type relabeling (#4376)

cbf9983

Update golang version to 1.24.6 (#4382)

c67a176

UlisesGascon closed this Aug 20, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

sync experiment#5

sync experiment#5
UlisesGascon wants to merge 340 commits into
nodesource:ns-main-ulises-expfrom
grafana:main

UlisesGascon commented Aug 12, 2025 •

edited

Loading

Uh oh!

coderabbitai Bot commented Aug 12, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR/Issue comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Status, Documentation and Community

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Uh oh!

Conversation

UlisesGascon commented Aug 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Aug 12, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR/Issue comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Status, Documentation and Community

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

UlisesGascon commented Aug 12, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)