ci: add typecheck step - #1030
Open
araujogui wants to merge 1 commit into
Open
Conversation
Nothing in CI ran tsc, so `erasableSyntaxOnly` (added in nodejs#252) left an unnoticed TS1294 on a pre-existing angle-bracket cast. Fixes the existing errors and gates them in CI.
MattIPv4
approved these changes
Sep 12, 2026
ovflowd
approved these changes
Sep 12, 2026
Member
|
I'm fine fast-tracking this as it improves resilience/CI. @nodejs/web-infra 👍 / 👎 for fast-tracking |
Member
|
👎 I don't see the need to fast-track this, it can wait, I'd like @flakey5 to review it if they have the time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No CI job ran
tsc, so type errors could land onmain. One had:erasableSyntaxOnly(#252) retroactively made a pre-existing angle-bracket cast insrc/utils/object.tsa TS1294 error.Adds
npm run typecheck(tsc --noEmitover both projects) and wires it into the Tests workflow. Also fixes the errors it surfaced:src/utils/object.ts— angle-bracket cast toas.e2e-tests/tsconfig.json— itstypesreplaced the inheritedworker-configuration.d.tsinstead of extending it, dropping every Workers global.src/worker.ts—withSentry<Env>passed one explicit type arg, so the handler type param fell back to its defaultExportedHandler<Env>with an optionalfetch. Passingtypeof handlerfixes the 20worker.fetch is possibly undefinederrors without touching the tests.CACHING: falsefrom the e2e tests; nothing reads it.