abort_controller: retain AbortSignal with registered listeners during gc#64415
Open
Phantom-d-e-v wants to merge 1 commit into
Open
abort_controller: retain AbortSignal with registered listeners during gc#64415Phantom-d-e-v wants to merge 1 commit into
Phantom-d-e-v wants to merge 1 commit into
Conversation
Per the DOM spec's "AbortSignal garbage collection" section, an AbortSignal with registered event listeners must not be garbage collected while those listeners are attached. Previously only timeout and non-empty composite signals were retained in gcPersistentSignals, so a signal that merely had a listener (e.g. the signal exposed by a fetch Request) could be collected while still in use, causing its listeners to silently stop firing after the owning object was gc'd. Fixes: nodejs#55428
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the DOM spec's "AbortSignal garbage collection" section, an AbortSignal with registered event listeners must not be garbage collected while those listeners are attached. Previously only timeout and non-empty composite signals were retained in gcPersistentSignals, so a signal that merely had a listener (e.g. the signal exposed by a fetch Request) could be collected while still in use, causing its listeners to silently stop firing after the owning object was gc'd.
Fixes: #55428