permission: add unique warning codes#64414
Open
davidje13 wants to merge 1 commit into
Open
Conversation
Adds unique warning codes of the form PERM0000 for all permissions related SecurityWarnings, so that they can be individually silenced if required. Fixes: nodejs#59818 Signed-off-by: David Evans <davidje13@users.noreply.github.com>
Collaborator
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64414 +/- ##
==========================================
+ Coverage 90.23% 90.24% +0.01%
==========================================
Files 741 741
Lines 241339 241337 -2
Branches 45464 45472 +8
==========================================
+ Hits 217766 217805 +39
+ Misses 15132 15085 -47
- Partials 8441 8447 +6
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds unique warning codes of the form
PERM0000for all permissions-relatedSecurityWarnings, so that they can be individually (and minimally) silenced if required, e.g.--disable-warning=PERM0002. See #59818 (comment) for an example use-case.There isn't much of an existing pattern for warning codes, except
DEP0000for deprecations, so this follows that convention. There are currently 2 other places which generateSecurityWarnings which should perhaps be given unique codes as well (something for a separate PR I think)Fixes: #59818