Skip to content

doc: add note about restricted CI to pull-requests.md #64321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sxa wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −0
Open

doc: add note about restricted CI to pull-requests.md #64321

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions doc/contributing/pull-requests.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,6 +540,13 @@ specific details of how to do this are included in the new collaborator
test run for you as approvals for the pull request come in.
If not, you can ask a collaborator or triager to start a CI run.

CI access is only available to collaborators and members of the platform
teams. If you are not yet in one of those teams then you will need someone
to relay the results to you. If a CI has been completed and failed and a
day or so has passed, it will be worth commenting in the issue to say you
cannot see what failed and to politely request in the PR that someone gives
you that information.

Ideally, the code change will pass ("be green") on all platform configurations
supported by Node.js. This means that all tests pass and there are no linting
errors. In reality, however, it is not uncommon for the CI infrastructure itself
Expand Down
Loading