net: make TCP Server and Socket transferable across worker threads#64225
Open
mcollina wants to merge 4 commits into
Open
net: make TCP Server and Socket transferable across worker threads#64225mcollina wants to merge 4 commits into
mcollina wants to merge 4 commits into
Conversation
Allow a listening net.Server or an accepted net.Socket to be moved to another thread by listing it in the transferList of a worker_threads postMessage() call. Unix only; Windows throws. Signed-off-by: Matteo Collina <hello@matteocollina.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Previously a transferred net.Socket stayed alive on the sending side and silently dropped writes. Destroy it so further use fails with ERR_STREAM_DESTROYED. Signed-off-by: Matteo Collina <hello@matteocollina.com>
mcollina
requested review from
Renegade334 and
addaleax
and removed request for
addaleax
Signed-off-by: Matteo Collina <hello@matteocollina.com>
jasnell
approved these changes
Jul 1, 2026
addaleax
approved these changes
Jul 5, 2026
addaleax
added
author ready
github-actions
Bot
removed
the
request-ci
Collaborator
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move a listening
net.Serveror an acceptednet.Socketto another thread via a worker_threadspostMessage()transferList. Unix only; Windows throws.