buffer: add fast api for isUtf8 and isAscii#64169
Merged
Merged
Conversation
9929ec2 to
0217108
Compare
Member
Author
|
Cc @nodejs/performance |
lemire
approved these changes
Jun 29, 2026
Collaborator
addaleax
reviewed
Jun 29, 2026
Member
Author
|
@addaleax PTAL, I did indeed find struct to be the cleaner here |
addaleax
approved these changes
Jun 30, 2026
Collaborator
Collaborator
mertcanaltin
approved these changes
Jul 2, 2026
Signed-off-by: Gürgün Dayıoğlu <hey@gurgun.day> PR-URL: nodejs#64169 Reviewed-By: Daniel Lemire <daniel@lemire.me> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
7907c52 to
c9f8721
Compare
Contributor
|
Landed in c9f8721 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64169 +/- ##
==========================================
+ Coverage 92.01% 92.04% +0.03%
==========================================
Files 379 381 +2
Lines 166972 169314 +2342
Branches 25554 25964 +410
==========================================
+ Hits 153639 155852 +2213
- Misses 13041 13173 +132
+ Partials 292 289 -3 🚀 New features to boost your workflow:
|
richardlau
pushed a commit
that referenced
this pull request
Jul 6, 2026
Signed-off-by: Gürgün Dayıoğlu <hey@gurgun.day> PR-URL: #64169 Reviewed-By: Daniel Lemire <daniel@lemire.me> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I like V8's fast api constraints, so I'm in the process of checking if there are any easy wins that we haven't yet spotted
Benchmarks (3 run avg, M5 Pro):
main:
branch: