[stable-24.0.x] Fix #6169: elect call offerer using same-namespace session IDs - #6460
Merged
Conversation
In HPB (external signaling) mode the remote participant sessionId passed to PeerConnectionWrapper is a signaling-layer session ID, while the local session used for the offerer election (callSession) is the Nextcloud session ID. The two peers then compare unrelated strings and can both compute the same role: both "not offerer" (no offer is created — the call deadlocks) or both "offerer" (offer collision). The requestoffer fallback only applies in MCU mode, so direct 2-party calls deadlock outright. Pass the local signaling session (webSocketClient.sessionId when external signaling is used, callSession otherwise — matching the existing currentSessionId resolution) so both peers compare the same namespace. Also extract the election into PeerConnectionWrapper.isOfferer() and add PeerConnectionWrapperOffererRoleTest covering the contract and the cross-namespace failure mode. Signed-off-by: Alain Lauzon <alauzon@alainlauzon.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
APK file: https://github.com/nextcloud/talk-android/actions/runs/31109742767/artifacts/8973325804 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #6375