[master] ci(actions): Update workflow templates from organization template repository#1049
Open
nextcloud-command wants to merge 2 commits into
Open
[master] ci(actions): Update workflow templates from organization template repository#1049nextcloud-command wants to merge 2 commits into
nextcloud-command wants to merge 2 commits into
Conversation
nextcloud-command
force-pushed
the
automated/noid/master-update-workflows
branch
from
July 19, 2026 05:40
7479914 to
f753767
Compare
kesselb
force-pushed
the
automated/noid/master-update-workflows
branch
from
July 20, 2026 20:21
2659ab4 to
39a7d36
Compare
…ository Signed-off-by: GitHub <noreply@github.com> Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
force-pushed
the
automated/noid/master-update-workflows
branch
from
July 20, 2026 20:22
39a7d36 to
29f9cba
Compare
kesselb
enabled auto-merge
July 20, 2026 20:22
WalkthroughCI workflows now use 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 4ae7aab3-5b03-4318-98f2-37d56947820e
📒 Files selected for processing (11)
.github/actions-lock.txt.github/workflows/lint-php-cs.yml.github/workflows/npm-audit-fix.yml.patch.github/workflows/phpunit-mariadb.yml.github/workflows/phpunit-mysql.yml.github/workflows/phpunit-oci.yml.github/workflows/phpunit-pgsql.yml.github/workflows/phpunit-sqlite.yml.github/workflows/pr-feedback.yml.github/workflows/psalm.yml.github/workflows/update-nextcloud-ocp.yml
Comment on lines
+132
to
+142
| - name: Remove nextcloud/ocp | ||
| # Only run if phpunit config file exists | ||
| if: steps.check_composer.outputs.files_exists == 'true' | ||
| working-directory: apps/${{ env.APP_NAME }} | ||
| run: | | ||
| composer remove nextcloud/ocp --dev --no-scripts | ||
| composer i | ||
|
|
||
| - name: Install composer dependencies | ||
| uses: ramsey/composer-install@65e4f84970763564f46a70b8a54b90d033b3bdda # 4.0.0 | ||
| with: | ||
| working-directory: apps/${{ env.APP_NAME }} |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Add missing condition to Install composer dependencies step.
By splitting the dependency setup into two separate steps, the Install composer dependencies step lost the condition that ensures composer.json exists. If composer.json is missing (which is a valid state for some apps), the ramsey/composer-install action will fail and break the CI run. Additionally, the comment copied from the PHPUnit step should be corrected.
.github/workflows/phpunit-mariadb.yml#L132-L142: Add the missingifcondition and fix the comment..github/workflows/phpunit-mysql.yml#L130-L140: Add the missingifcondition and fix the comment..github/workflows/phpunit-oci.yml#L137-L147: Add the missingifcondition and fix the comment..github/workflows/phpunit-pgsql.yml#L128-L138: Add the missingifcondition and fix the comment..github/workflows/phpunit-sqlite.yml#L117-L127: Add the missingifcondition and fix the comment.
💻 Proposed fix
- name: Remove nextcloud/ocp
- # Only run if phpunit config file exists
+ # Only run if composer config file exists
if: steps.check_composer.outputs.files_exists == 'true'
working-directory: apps/${{ env.APP_NAME }}
run: |
composer remove nextcloud/ocp --dev --no-scripts
- name: Install composer dependencies
+ if: steps.check_composer.outputs.files_exists == 'true'
uses: ramsey/composer-install@65e4f84970763564f46a70b8a54b90d033b3bdda # 4.0.0
with:
working-directory: apps/${{ env.APP_NAME }}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| - name: Remove nextcloud/ocp | |
| # Only run if phpunit config file exists | |
| if: steps.check_composer.outputs.files_exists == 'true' | |
| working-directory: apps/${{ env.APP_NAME }} | |
| run: | | |
| composer remove nextcloud/ocp --dev --no-scripts | |
| composer i | |
| - name: Install composer dependencies | |
| uses: ramsey/composer-install@65e4f84970763564f46a70b8a54b90d033b3bdda # 4.0.0 | |
| with: | |
| working-directory: apps/${{ env.APP_NAME }} | |
| - name: Remove nextcloud/ocp | |
| # Only run if composer config file exists | |
| if: steps.check_composer.outputs.files_exists == 'true' | |
| working-directory: apps/${{ env.APP_NAME }} | |
| run: | | |
| composer remove nextcloud/ocp --dev --no-scripts | |
| - name: Install composer dependencies | |
| if: steps.check_composer.outputs.files_exists == 'true' | |
| uses: ramsey/composer-install@65e4f84970763564f46a70b8a54b90d033b3bdda # 4.0.0 | |
| with: | |
| working-directory: apps/${{ env.APP_NAME }} |
📍 Affects 5 files
.github/workflows/phpunit-mariadb.yml#L132-L142(this comment).github/workflows/phpunit-mysql.yml#L130-L140.github/workflows/phpunit-oci.yml#L137-L147.github/workflows/phpunit-pgsql.yml#L128-L138.github/workflows/phpunit-sqlite.yml#L117-L127
Collaborator
|
@coderabbitai help |
ChatThere are 3 ways to chat with CodeRabbit:
CodeRabbit commands
Other keywords and placeholders
CodeRabbit configuration file (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated update of all workflow templates from nextcloud/.github