fix: wire up Abandon button in Job Detail and Active Rips UI - #143
Open
negativeeddy wants to merge 1 commit into
Open
fix: wire up Abandon button in Job Detail and Active Rips UI#143negativeeddy wants to merge 1 commit into
negativeeddy wants to merge 1 commit into
Conversation
- Add 'Abandon' button next to Cancel in JobDetail.cshtml
- Add 'Abandon' button next to View in _ActiveJobRows.cshtml
- Include Abandon in the SignalR dynamic button injection
- Uses the existing arm.abandonJob() JS helper and POST /api/abandon/{id} endpoint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the missing Abandon button to the UI, wiring up the already-implemented
arm.abandonJob(jobId)JavaScript helper andPOST /api/abandon/{id}endpoint.What changed
Behavior
btn-outline-warning(⚠) to distinguish from the red Cancel buttonWhy
The Abandon button was fully implemented (JS helper + API endpoint + integration tests) but never wired into any UI — making it dead code. This fix completes the feature.
Closes #75