Skip to content

fix: enforce OvidSubmitEnabled and handle 429 rate limits (closes #133, closes #134) - #135

Merged
negativeeddy merged 1 commit into
masterfrom
fix/code-review-#87
Aug 18, 2026
Merged

fix: enforce OvidSubmitEnabled and handle 429 rate limits (closes #133, closes #134)#135
negativeeddy merged 1 commit into
masterfrom
fix/code-review-#87

Conversation

@negativeeddy

Copy link
Copy Markdown
Owner

Code Review Fix

Automated fix from deep-review investigation of #87.

Fixes #133
Fixes #134

Changes

Bug #1OvidSubmitEnabled enforcement (#133):

  • Injected IOptions<ArmSettings> into OvidSubmitService
  • Added early-return check in SubmitJobAsync when setting is false
  • Added short-circuit in GetPendingJobsAsync to return empty list when disabled

Bug #2 — Rate limit handling (#134):

  • Added explicit HTTP 429 handling in RegisterFingerprintAsync with Retry-After header logging
  • Added explicit HTTP 429 handling in SubmitDiscAsync with Retry-After header logging
  • Matches existing 429 handling in LookupByFingerprintAsync

Testing

  • All 464 existing tests pass
  • Build succeeds with 0 warnings, 0 errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle rate limit (429) in OVID submission write paths Enforce OvidSubmitEnabled setting in OvidSubmitService

1 participant