Skip to content

Low: ManualSelectionTrackNumbers is never cleared after being applied #176

Description

@negativeeddy

ManualSelectionTrackNumbers is never cleared after being applied

Source: Code review (automated)
Date: 2026-09-02
Scope: Recent changes (Manual Selection rip mode, PR #144)
File(s): src/ArmRipper.Core/Rip/ArmRipperService.cs

Problem

After the selection is applied, job.ManualSelectionTrackNumbers remains persisted. If the job is later resumed or re-processed, the stale selection could be re-applied unexpectedly. It should be cleared after consumption.

Proposed Fix

Set job.ManualSelectionTrackNumbers = null and save after applying the selection.

Notes

Stale data risk on job resume/reprocess.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions