ManualSelectionTrackNumbers is never cleared after being applied
Source: Code review (automated)
Date: 2026-09-02
Scope: Recent changes (Manual Selection rip mode, PR #144)
File(s): src/ArmRipper.Core/Rip/ArmRipperService.cs
Problem
After the selection is applied, job.ManualSelectionTrackNumbers remains persisted. If the job is later resumed or re-processed, the stale selection could be re-applied unexpectedly. It should be cleared after consumption.
Proposed Fix
Set job.ManualSelectionTrackNumbers = null and save after applying the selection.
Notes
Stale data risk on job resume/reprocess.
ManualSelectionTrackNumbers is never cleared after being applied
Source: Code review (automated)
Date: 2026-09-02
Scope: Recent changes (Manual Selection rip mode, PR #144)
File(s):
src/ArmRipper.Core/Rip/ArmRipperService.csProblem
After the selection is applied,
job.ManualSelectionTrackNumbersremains persisted. If the job is later resumed or re-processed, the stale selection could be re-applied unexpectedly. It should be cleared after consumption.Proposed Fix
Set
job.ManualSelectionTrackNumbers = nulland save after applying the selection.Notes
Stale data risk on job resume/reprocess.