Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Evergreen-backed manual/integration test suite to validate that the Node.js driver can connect and authenticate through an Atlas Secure Frontend Processor (SFP / monguard), aligned with the referenced SFP testing spec.
Changes:
- Added
test/manual/sfp.test.tscovering unauthenticated, SCRAM-SHA-256, and X.509 scenarios (with variation runs for compression and Server API v1). - Added a new
check:sfpnpm script and Evergreen wiring (test-sfptask +run-sfp-tests.sh) including secrets setup and X.509 cert materialization. - Registered the task in Evergreen generation/config so it runs on targeted build variants.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/manual/sfp.test.ts | New SFP test suite asserting connectivity/auth and basic operations through SFP |
| package.json | Adds check:sfp script to execute the new test file |
| .evergreen/run-sfp-tests.sh | Fetches secrets, writes X.509 cert PEM, and runs check:sfp |
| .evergreen/generate_evergreen_tasks.js | Registers new test-sfp task with appropriate tags/commands |
| .evergreen/config.yml | Adds run sfp tests function and schedules test-sfp across variants |
| .evergreen/config.in.yml | Source config updates for the new run sfp tests function |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds integration tests that verify the Node driver connects and authenticates correctly through an Atlas Secure Frontend Processor (SFP / monguard), per the SFP testing spec.
Covers unauthenticated, SCRAM-SHA-256, and X.509 auth, each asserting
ping,connectionStatus, and CRUD - with the authenticated cases also run under a compressor (zlib) and Server API v1. Credentials come from AWS Secrets Manager (drivers/sfp).Wired up as a new
test-sfpEvergreen task (test/manual/sfp.test.ts+.evergreen/run-sfp-tests.sh,check:sfp), running on the rhel8 and Windows variants.Double check the following
npm run check:lint)type(NODE-xxxx)[!]: description