Fix: fix passkey translation keys#6512
Open
DeDiamondPro wants to merge 2 commits into
Open
Conversation
DeDiamondPro
commented
Jun 26, 2026
DeDiamondPro
commented
Contributor
- Fixed common messages "remove" being updated to "delete passkey", seems like a small mistake from this commit 4eabe2a (i18n - String improvement megathread #5734 (comment))
- Split header and button translation keys (i18n - String improvement megathread #5734 (comment)
Member
Pull request changelogAppAddedChangedDeprecatedRemovedFixedSecurityWebsiteAddedChangedDeprecatedRemovedFixedSecurityHostingAddedChangedDeprecatedRemovedFixedSecurity |
tdgao
approved these changes
Jun 26, 2026
tdgao
left a comment
tdgao
left a comment
Contributor
There was a problem hiding this comment.
TY for the fix! Yes that was a mistake
Contributor
Author
|
The test failing seems to be a Rust compilation error, but I didn’t touch any of that, so I’m not too sure what’s causing that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.