Skip to content

feat: add retries - #36

Merged
wpbonelli merged 3 commits into
modflowpy:mainfrom
wpbonelli:retry-download
Sep 7, 2026
Merged

feat: add retries#36
wpbonelli merged 3 commits into
modflowpy:mainfrom
wpbonelli:retry-download

Conversation

@wpbonelli

@wpbonelli wpbonelli commented Sep 7, 2026

Copy link
Copy Markdown
Member

motivated by MODFLOW-ORG/modflowapi#117. also bump the Python version to 3.11

wpbonelli and others added 3 commits September 7, 2026 08:25
The action fetches executables from GitHub at the start of a job. That
connection is occasionally reset (URLError: [Errno 104] Connection reset
by peer), failing the job before any later step runs. Consumers have been
working around this by wrapping the whole action in continue-on-error
plus a duplicated retry step; doing it once here removes that boilerplate.

- New `retries` (default 3) and `retry_wait_seconds` (default 5) inputs.
- The get-modflow invocation runs in a retry loop bounded by `retries`.
- The release-metadata and install-script curl calls get `--retry`
  /`--retry-all-errors` with the same values; the script download also
  gains `--fail` so an error page is no longer written to disk.
- Set `retries: 0` to keep the previous single-attempt behavior.

`--retry-all-errors` requires curl >= 7.71 (2020); GitHub-hosted runners
ship curl 8.x.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019uDL3ZYVHT8svJ9Fu1Ayed
flopy now requires >=3.11, so `pip install flopy` fails on the 3.10
runners with "Package 'flopy' requires a different Python".

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019uDL3ZYVHT8svJ9Fu1Ayed
@wpbonelli
wpbonelli merged commit 98af92b into modflowpy:main Sep 7, 2026
159 checks passed
@wpbonelli
wpbonelli deleted the retry-download branch September 7, 2026 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant