Skip to content

ci: drop discontinued vtk-osmesa headless workaround - #2848

Merged
wpbonelli merged 1 commit into
modflowpy:developfrom
wpbonelli:fix-vtk-osmesa-headless
Sep 9, 2026
Merged

ci: drop discontinued vtk-osmesa headless workaround#2848
wpbonelli merged 1 commit into
modflowpy:developfrom
wpbonelli:fix-vtk-osmesa-headless

Conversation

@wpbonelli

Copy link
Copy Markdown
Member

use pyvista/setup-headless-display-action everywhere and drop the old osmesa workaround

Since VTK 9.4 the standard `vtk` wheel bundles OSMesa and EGL support and
selects a backend at runtime, and Kitware stopped publishing the separate
`vtk-osmesa` wheels (last build is 9.3.x / cp312, Sept 2024). With the rtd
env now resolving vtk 9.7 on Python 3.13, the "OpenGL workaround" step fails
with "No matching distribution found for vtk-osmesa".

Remove the swap in both workflows:
- rtd.yml already runs pyvista/setup-headless-display-action, which handles
  headless rendering for the unified wheel, so just delete the step.
- examples.yml had no headless display setup; replace the swap with the same
  pyvista/setup-headless-display-action.

The notebooks render off-screen with the "static" jupyter backend, so trame
is not needed.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Mvow13NzVZK7DhdzJ8Q8Bz
@wpbonelli
wpbonelli marked this pull request as ready for review September 9, 2026 20:47
@wpbonelli wpbonelli added this to the 3.11.1 milestone Sep 9, 2026
@codecov

codecov Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.6%. Comparing base (556c088) to head (8285c53).
⚠️ Report is 231 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2848      +/-   ##
===========================================
+ Coverage     55.5%    73.6%   +18.0%     
===========================================
  Files          644      659      +15     
  Lines       124135   132282    +8147     
===========================================
+ Hits         68947    97403   +28456     
+ Misses       55188    34879   -20309     

see 586 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wpbonelli
wpbonelli merged commit 999b055 into modflowpy:develop Sep 9, 2026
24 checks passed
@wpbonelli
wpbonelli deleted the fix-vtk-osmesa-headless branch September 9, 2026 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant