test(postprocessing): check signed magnitudes in 1-D faceflow cases - #2846
Open
TameTheGame wants to merge 1 commit into
Open
test(postprocessing): check signed magnitudes in 1-D faceflow cases#2846TameTheGame wants to merge 1 commit into
TameTheGame wants to merge 1 commit into
Conversation
TameTheGame
marked this pull request as ready for review
September 9, 2026 02:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing one-dimensional
get_structured_faceflowscases check whether the active-direction array contains nonzero values. Add an independent physical reference: unit conductivity and cell dimensions with prescribed heads 11, 12 and 13 imply face flows[-1, -1, 0]toward increasing column, row or layer number. Check the absent terminal face is exactly zero.This adds ten lines and preserves all seven existing parameterizations, model inputs, simulation calls and dependencies. It is a test improvement; no existing implementation defect is claimed.
Validation on base
18dc192cac9ed731dc84f40bc898e0f4d9f87e20:6.8.0+8680167.dirty.[-1, -1, 0].The full FloPy test suite and project-wide release checks were not run locally. The upstream base has successful workflows, but those results do not validate this patch. I am opening this as a draft pending CI and maintainer review. Please let me know whether the targeted local checks plus CI on this commit are sufficient for this assertion-only change, or whether you require additional local validation before this leaves draft status.
Related PR #2746 adds broader conversion/round-trip coverage and leaves this existing assertion block unchanged at the head inspected. This patch is limited to the existing physical 1-D cases.
AI assistance: OpenAI Codex using GPT-6 Astra assisted with the assessment, patch and local validation.