feat(viewer): make the sidebar wordmark a home link#123
Merged
Conversation
Clicking "sideshow" (aside or mobile topbar) now clears the current session and returns to the session-less base route — a guaranteed way back to the board from anywhere. The wordmark is a real <button> so it's keyboard- and screen-reader-reachable. New goHome() always asks the host to navigate; it never short-circuits on the engine's own selection, so an embedding host that layers a view over the board (e.g. sideshow cloud's full-page Settings, which has no session rows to click out of on an empty board) gets a reliable exit through the same click. The host dedupes a no-op move, and applyRoute ignores a null sessionId, so back/forward to home doesn't thrash a load. Self-hosted behaviour is otherwise unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The sidebar wordmark is now a home link. Clicking "sideshow" (in the aside, or the mobile topbar) clears the current session and returns to the session-less base route — a guaranteed way back to the board from anywhere. It's a real
<button>, so it's keyboard- and screen-reader-reachable.Why
On an empty board, the way you leave a host-projected full-pane view is by clicking a session in the sidebar — but with zero sessions there are no rows to click, so there was no in-app exit (only browser-back). sideshow cloud's full-page Settings (rendered through the
ss:mainslot from #119) hits exactly this: open Settings on a fresh, session-less account and the only way out was the back button.The new
goHome()always asks the host to navigate — it never short-circuits on the engine's own selection — so an embedding host that layers its own view over the board gets a reliable exit through the same click; the host dedupes a no-op move.applyRouteignores a nullsessionId, so back/forward to home doesn't thrash a session load, and we deselect ingoHomeitself.Scope / parity
Tests
url-routing.spec.ts): select a session → click the wordmark → URL drops/session/:idand the row deselects.🤖 Generated with Claude Code