feat: reject auth servers lacking S256 PKCE support#955
Open
DaleSeo wants to merge 1 commit into
Open
Conversation
9029a36 to
d46e287
Compare
d46e287 to
f59dd43
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The client always sends an
S256PKCE challenge, but when the server's metadata advertisedcode_challenge_methods_supportedwithoutS256,validate_server_metadataonly warned and continued. So rmcp would start a flow the server can't complete and fail confusingly mid-exchange. It now returnsAuthError::PkceUnsupportedup front for that case, matching the TypeScript SDK. A server that omits the field entirely is still allowed by default, and callers wanting the stricter spec behavior can opt in withset_require_pkce_support(true).How Has This Been Tested?
New unit tests cover the matrix.
Breaking Changes
None. Only behavioral change.
Types of changes
Checklist