feat: allow opting into private oauth metadata hosts#954
Open
DaleSeo wants to merge 2 commits into
Open
Conversation
github-actions
Bot
added
T-core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The SSRF hardening in PR #935 blocks loopback and private-network metadata hosts with no opt-out, which breaks local dev, some enterprise setups, and the client side of the official conformance suite that uses
127.0.0.1. This adds an opt-inset_allow_private_metadata_hostsonAuthorizationManagerandOAuthStateto allow only loopback/private hosts while still rejecting cloud-metadata and link-local addresses.How Has This Been Tested?
New unit tests cover the guard directly.
Breaking Changes
None.
Types of changes
Checklist