FIX: don't mutate cached ICA sources in plot_sources properties - #14303
Merged
Conversation
DerAndereJohannes
force-pushed
the
ica_pick_fix
branch
from
September 12, 2026 01:10
9d05fa6 to
4bf5bac
Compare
DerAndereJohannes
requested review from
agramfort and
larsoner
as code owners
September 12, 2026 01:10
Member
|
Oof yes this looks like a clear bug, thanks @DerAndereJohannes ! |
larsoner
enabled auto-merge (squash)
September 12, 2026 15:21
larsoner
pushed a commit
that referenced
this pull request
Sep 12, 2026
… sources in plot_sources properties) (#14305) Co-authored-by: Johannes Herforth <johannes@herforth.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Found a bug when right clicking the IC number on the left side (opening the ica_properties) when in
plot_sources. There seems to have been a regression from the previous versions where on the first right click it works fine, but on the second it crashes with an index error:It turns out that using the picks command was mutating the browser cached data in place and therefore only worked the first time. Regression test was also added. The fix was just adding a copy before doing the picks.
Let me know if you have any other questions.