FIX: Warn when bridged interpolation uses bad channels - #14287
Open
Deepnar wants to merge 1 commit into
Open
Conversation
Deepnar
requested review from
agramfort,
drammock and
larsoner
as code owners
September 9, 2026 11:14
|
Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
interpolate_bridged_electrodestemporarily clearsinst.info["bads"]while building the interpolation. This can allow channels already marked bad to influence the result without notifying the caller.This patch keeps the existing interpolation behavior and public API unchanged, but emits a warning naming the affected channels and documents the behavior.
Changes
inst.info["bads"]is non-empty.Testing
.venv/bin/python -m pytest -p no:pytest-qt mne/preprocessing/tests/test_interpolate.py::test_interpolate_bridged_electrodes --verbose— 1 passed.venv/bin/python -m pytest -p no:pytest-qt mne/preprocessing/tests/test_interpolate.py --verbose— 11 passed.venv/bin/python -m pytest -p no:pytest-qt mne/tests/test_docstring_parameters.py --verbose— 17 passed, 2 skippedgit diff --checkpassedCloses #14263.