Gate deployment on tests passing - #2
Merged
Merged
Conversation
The benchmark code block in first-post imports tabulate but it was missing from pyproject.toml, causing test_markdown_code_block[first-post-block-6] to fail with ModuleNotFoundError. Co-Authored-By: Oz <oz-agent@warp.dev>
Add a test job to the deploy workflow that calls the reusable test workflow. The build job now depends on test succeeding, so if tests fail the site is never built or deployed. Also add workflow_call trigger to test.yml so it can be used as a reusable workflow. Co-Authored-By: Oz <oz-agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ensures tests must pass before the site is deployed to GitHub Pages.
Changes
deploy.yml: Added atestjob that calls the reusable test workflow (.github/workflows/test.yml). Thebuildjob now hasneeds: test, so if tests fail, the build and deploy steps are skipped entirely.test.yml: Addedworkflow_call:trigger so it can be invoked as a reusable workflow from the deploy pipeline.Flow
If any step fails, subsequent steps are not executed.
This PR was generated with Oz.