RSC-first architecture: Apollo scoping, server prefetch, playground cleanup - #187
Merged
Merged
Conversation
…fetch - Route groups: (marketing) vs (app) with Apollo-only InteractiveDataProviders - Privacy page: server-rendered PrivacyPageContent inside client PrivacyPageShell - Playground: server-prefetch via getPlaygroundInitialData + tRPC initialData hydration - LocaleAppPageShell is a Server Component; ProjectBrowser loads via dynamic import - Add loading.tsx skeletons for playground and profile instant routes - Fix stale layout comments about session streaming Co-authored-by: maxim.kayander1 <maxim.kayander1@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…ions - Add vibe-docs/RSC-First-Refactor-Plan.md with phases 2–5 - Cache public project SEO fields with use cache + cacheTag per slug - Use loadI18nForLocale in resolvePlaygroundPageSeo (reuse cached i18n) - Wrap playground navigateTo in startTransition for Instant Nav UX Co-authored-by: maxim.kayander1 <maxim.kayander1@gmail.com>
- getCaseBySlug: map Prisma P2025 to TRPC NOT_FOUND (parity with getBySlug) - getPlaygroundInitialData: keep project prefetch when case lookup fails - Add regression test for invalid case slug Co-authored-by: maxim.kayander1 <maxim.kayander1@gmail.com>
…tests - revalidatePlaygroundProjectSeo on project create/update/delete/deleteAll - Session-aware loadProjectSeoFieldsForSession for owner/admin private SEO - Remove redundant playground Suspense; rely on loading.tsx - Add daily loading.tsx skeletons - Split queryPublicProjectSeoFields for testability; fix revalidateTag profile arg - Add unit tests for SEO helpers and invalid project slug prefetch Co-authored-by: maxim.kayander1 <maxim.kayander1@gmail.com>
Co-authored-by: maxim.kayander1 <maxim.kayander1@gmail.com>
mkayander
marked this pull request as ready for review
September 6, 2026 13:47
…cker - PlaygroundPageLoading/PlaygroundPageShell share chrome with live page (header + bg) - Route loading.tsx uses full shell instead of bare SplitPanelsLayoutSkeleton - Replace useHasMounted gate with SplitPanelsLayoutClient (dynamic, ssr: false) - usePlaygroundMobileLayout uses SSR device hint to avoid mobile/desktop flash - Align split layout height with PLAYGROUND_DESKTOP_APP_BAR_HEIGHT (56px) Co-authored-by: maxim.kayander1 <maxim.kayander1@gmail.com>
Move PlaygroundPageShell to a persistent playground layout so loading.tsx only swaps the panel skeleton while chrome stays mounted. Prefetch the split layout chunk and drop the dynamic loading fallback to avoid a second skeleton pass. Warm Pyodide from the layout segment instead of CodePanel mount so init and the progress snackbar are not restarted when the route loading UI hands off to the page. Co-authored-by: maxim.kayander1 <maxim.kayander1@gmail.com>
Add PlaygroundPanelsGate to keep one continuous skeleton from route loading through split-layout hydration and editor init. Reset project loading state on playground layout entry, and skip loadStart on the initial auto-project redirect so panel overlays do not flash back on. Co-authored-by: maxim.kayander1 <maxim.kayander1@gmail.com>
Co-authored-by: maxim.kayander1 <maxim.kayander1@gmail.com>
…llelization - Reset panel loading gate when playground URL segments change (back/forward, Link navigations) via usePlaygroundSlugLoadingSync - Consolidate split-layout prefetch into prefetchSplitPanelsLayout helper - Parallelize allBrief + getBySlug in getPlaygroundInitialData - Unblock loading gate when project has no cases or no solutions - Add use client directives to playground runtime hooks - Fix locale-aware home link on privacy page - Add tests for slug loading sync Co-authored-by: maxim.kayander1 <maxim.kayander1@gmail.com>
Resolve incomplete playground URLs on the server (project/case/solution defaults plus last-visit cookie restore) before prefetching, instead of chaining three client-side navigations from TestCaseSelectBar and SolutionSelectBar. - Add buildCanonicalPlaygroundSlug and resolveCanonicalPlaygroundRedirect - Mirror lastPlaygroundPath to a cookie for server-side restore - Extend getPlaygroundInitialData with solution prefetch - Remove client auto-select effects for project/case/solution defaults - Map getSolutionBySlug NOT_FOUND like getCaseBySlug Co-authored-by: maxim.kayander1 <maxim.kayander1@gmail.com>
Extract createApolloClient factory and ApolloHydrationProvider for route-scoped cache hydration. Daily and profile pages prefetch LeetCode GraphQL on the server; playground no longer mounts Apollo globally. Co-authored-by: maxim.kayander1 <maxim.kayander1@gmail.com>
Move ProjectBrowserProvider to playground layout only; add optional context for MainAppBar on other routes. Cache anonymous allBrief for server prefetch and canonical redirects. Skip redundant loadStart when server prefetch matches URL; append mobile ?view=code in canonical redirect. Update e2e for full slug paths. Co-authored-by: maxim.kayander1 <maxim.kayander1@gmail.com>
Instant-nav skeletons for home and privacy routes. Document completed Phase 2 architecture items in vibe-docs. Co-authored-by: maxim.kayander1 <maxim.kayander1@gmail.com>
cursor
Bot
changed the title
…ollo for ProjectModal - Revert getPlaygroundInitialData to live tRPC allBrief (not use cache) for client hydration - Add serializePlaygroundInitialData to strip cache metadata before client boundary - JSON-serialize loadCachedPublicProjectsBrief for server-only redirect cache - Add useClientCanonicalPlaygroundRedirect for soft-nav canonical URL updates - Mount ApolloHydrationProvider on playground for ProjectModal LeetCode import - Update E2E specs to wait for canonical invert-binary-tree path Co-authored-by: maxim.kayander1 <maxim.kayander1@gmail.com>
- Skip server/client canonical redirect on bare /playground without last-visit cookie - Keep /de/playground indexable with Playground SEO title and canonical URL - Wait for visible app bar home link before clicking in E2E helpers - Only assert WebGL context-lost console messages after returning to home Co-authored-by: maxim.kayander1 <maxim.kayander1@gmail.com>
Co-authored-by: maxim.kayander1 <maxim.kayander1@gmail.com>
- Add MarketingLayoutClient with shared MainLayout/PageScrollContainer for home and privacy - Home hero reads scroll viewport from MarketingScrollContext - Remove per-page PrivacyPageShell that remounted scroll container on instant nav - Bail setIsScrolled reducer when value unchanged; simplify scroll handler Co-authored-by: maxim.kayander1 <maxim.kayander1@gmail.com>
…y chrome - Desktop bare /playground: panels ready + auto-open project browser - Revalidate PUBLIC_PROJECTS_BRIEF_CACHE_TAG on public project mutations - Share appendPlaygroundMobileViewQuery for server + client canonical redirects - Reset redirectingRef on pathname change; append ?view=code on mobile client nav - Persistent AppChromeLayoutClient for daily (app bar scroll on instant nav) - Tests for mobile view query, cache revalidation, desktop bare panels ready Co-authored-by: maxim.kayander1 <maxim.kayander1@gmail.com>
|
🎉 This PR is included in version 1.392.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code review follow-ups (2316847)
Fixed
/playground—usePlaygroundPanelsReadyno longer blocks forever;useBarePlaygroundBrowseLandingauto-opens project browser on indexable landing.revalidatePublicPlaygroundProjectbustsplayground-public-projects-brieftag alongside per-project SEO on create/update/delete.appendPlaygroundMobileViewQueryused by server + client; adds?view=codewhen canonicalizing on mobile without an existing view param.redirectingRefwedge — Cleared on pathname change inuseClientCanonicalPlaygroundRedirect.AppChromeLayoutClientin daily layout; removed per-pageMainLayoutfromDailyPageView.Tests added
appendPlaygroundMobileViewQuery.test.tsplaygroundProjectSeoCache.test.ts/playgroundcase inusePlaygroundPanelsReady.test.tsxVerification
pnpm lint✅pnpm test:ci✅app-locale-routes,instant-playground-nav✅