Skip to content

Weekly Permissions sync 2026-09-08 - #1621

Merged
Jason Johnston (jasonjoh) merged 1 commit into
masterfrom
permissions-update/2026-09-08
Sep 8, 2026
Merged

Jason Johnston (jasonjoh) merged 1 commit into
masterfrom
permissions-update/2026-09-08

Conversation

@marabooy

Copy link
Copy Markdown
Contributor

Weekly Permissions sync 2026-09-08

@marabooy
David (marabooy) requested a review from a team as a code owner September 8, 2026 00:41
Copilot AI lite review requested due to automatic review settings September 8, 2026 00:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The newly added managed license paths use casing (/virtualendpoint/managedlicenses) inconsistent with the existing managed licenses base path (/virtualEndpoint/managedLicenses), creating duplicate case-variant keys that can break exact-match permission lookups.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Weekly permissions catalog sync updating permissions/new/permissions.json to include newly surfaced Cloud PC managed license operation endpoints so they can be mapped to the appropriate permission schemes.

Changes:

  • Added a GET function path for retrieving a managed license operation by operationrequestid.
  • Added a POST action path for submitting a managed license operation.
  • Added corresponding entries across the relevant path sets for CloudPC.Read.All.
File summaries
File Description
permissions/new/permissions.json Adds new Cloud PC managed license operation endpoints to the permissions-to-path mapping catalog.
Review details

Suppressed comments (2)

permissions/new/permissions.json:12102

  • This GET path uses /virtualendpoint/managedlicenses, while the related managed licenses collection path directly above is /virtualEndpoint/managedLicenses. To avoid duplicate, case-variant keys (and potential lookup misses), update this entry to the same casing as the existing managed licenses path.
    permissions/new/permissions.json:12161
  • This POST action is recorded under /virtualendpoint/managedlicenses, but the managed licenses collection path elsewhere in this permission uses /virtualEndpoint/managedLicenses. Using a different casing creates a separate JSON key and can prevent consumers from finding the permission mapping for requests made to the canonical path. Align this path casing with the existing managed licenses entry.
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread permissions/new/permissions.json
@jasonjoh
Jason Johnston (jasonjoh) merged commit 0c140cd into master Sep 8, 2026
5 checks passed
@jasonjoh
Jason Johnston (jasonjoh) deleted the permissions-update/2026-09-08 branch September 8, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants