Skip to content

chore: remove unused handover-translations workflow #1615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jingjing Jia (jingjingjia-ms) merged 2 commits into from
Sep 2, 2026
Merged

chore: remove unused handover-translations workflow #1615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac8e5c9
chore: remove unused handover-translations workflow
jingjingjia-ms Sep 2, 2026
88b2292
chore: remove references to the handover-translations workflow
jingjingjia-ms Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/instructions/ci-workflows.instructions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,4 @@ applyTo: '.github/workflows/*.yml'
- When changing validation scope, update the same path set in `validate.yml` `paths` and `validate-patch.yml` `paths-ignore`: the canonical sample catalog, `scripts/**`, `tests/**`, and both npm manifest files.
- Preserve the `validate-json-schema` and `test` job names in both validation workflows because the patch workflow supplies their stand-in results.
- Keep the Jest `test` job dependent on `validate-json-schema` in `.github/workflows/validate.yml`.
- In the translation handoff, preserve the staging step that collects localized files before opening the cross-repository pull request.
- Reference credentials through GitHub Actions secrets, following `.github/workflows/handover-translations.yml`; never inline credential values.
- Get explicit approval before changing triggers, required-check behavior, permissions, secrets, or cross-repository handoff destinations.
38 changes: 0 additions & 38 deletions .github/workflows/handover-translations.yml
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ This repository publishes content rather than running an application service. Va

> **WARNING:** Production publication and cross-repository handoff are destructive or externally visible operations. Always get explicit user approval before:
> - Running or changing the production publication behavior in `azure-pipelines/publishSamples.yml`.
> - Running or changing the translation handoff behavior in `.github/workflows/handover-translations.yml`.
> - Changing protected-branch, required-check, credential, or secret handling.

### Rules
Expand All @@ -35,8 +34,6 @@ This repository publishes content rather than running an application service. Va

## Secrets Management

GitHub Actions accesses credentials through repository secrets in `.github/workflows/handover-translations.yml`, including `API_TOKEN_GITHUB`, `ACTION_EMAIL`, and `ACTION_USERNAME`.

### Rules for AI Agents

- Never inline secrets, tokens, passwords, connection strings, certificate material, or secret values.
Expand Down
16 changes: 4 additions & 12 deletions repo-context.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,7 @@ The repository follows a content pipeline rather than an application service lay
2. `tests/samples.schema.json` and the Jest specifications under `tests/` validate the sample-query and permission content through `scripts/test-initiator.js`.
3. `.github/workflows/validate.yml` runs schema validation and the npm test suite for relevant pull requests and pushes.
4. `azure-pipelines/publishSamples.yml` packages sample-query and permission files and uploads them to Azure Blob Storage from `master`.
5. `.github/workflows/handover-translations.yml` copies translated `messages/GE_*` files to `microsoftgraph/microsoft-graph-explorer-v4` from the `dev` branch.
6. The DevX API and Graph Explorer consume the published content, as described in `README.md`.
5. The DevX API and Graph Explorer consume the published content, as described in `README.md`.

---

Expand All @@ -83,7 +82,7 @@ The repository follows a content pipeline rather than an application service lay
- The unsuffixed JSON file is the base content file, such as `GE.json`, `sample-queries.json`, or `permissions-descriptions.json`.
- Localized files append an underscore and locale code before `.json`, such as `_de-DE`, `_fr-FR`, or `_zh-CN`.
- Jest test files use the `.spec.js` suffix.
- GitHub workflow file names describe their action, such as `validate.yml`, `validate-patch.yml`, and `handover-translations.yml`.
- GitHub workflow file names describe their action, such as `validate.yml` and `validate-patch.yml`.

---

Expand All @@ -93,14 +92,14 @@ The repository follows a content pipeline rather than an application service lay
|--------|------|-----------|-------|
| Content catalogs | JSON documents | `sample-queries/sample-queries.json`, `permissions/permissions-descriptions.json`, `permissions/new/permissions.json`, `permissions/new/provisioningInfo.json`, `messages/GE.json`, `ge-tour/tour-steps.json` | Canonical and localized data consumed outside this repository. |
| Validation configuration | npm script and JSON Schema | `package.json`, `tests/samples.schema.json`, `scripts/test-initiator.js` | `npm run test` starts Jest; GitHub Actions separately validates the sample catalog against its schema. |
| GitHub automation | GitHub Actions YAML | `.github/workflows/validate.yml`, `.github/workflows/validate-patch.yml`, `.github/workflows/handover-translations.yml` | Path filters select validation or translation handoff behavior. |
| GitHub automation | GitHub Actions YAML | `.github/workflows/validate.yml`, `.github/workflows/validate-patch.yml` | Path filters select validation behavior. |
| Publication automation | Azure Pipelines YAML | `azure-pipelines/publishSamples.yml` | Packages sample-query and permission content and publishes it to Azure Blob Storage. |
| Branch governance | Repository policy YAML and CODEOWNERS | `.github/policies/microsoft-graph-devx-content-branch-protection.yml`, `.github/CODEOWNERS` | Protects `master` and `dev` and assigns repository-wide ownership. |

### Config Disambiguation

- `package.json` defines the local test command and development dependencies; `tests/samples.schema.json` defines the allowed shape of sample-query content.
- GitHub Actions validate pull requests and hand off translations; `azure-pipelines/publishSamples.yml` handles production artifact publication.
- GitHub Actions validate pull requests; `azure-pipelines/publishSamples.yml` handles production artifact publication.

---

Expand All @@ -112,7 +111,6 @@ The repository follows a content pipeline rather than an application service lay
- `tests/permissions-descriptions.spec.js` - checks display-name formatting in the canonical permission descriptions.
- `.github/workflows/validate.yml` - CI entry point for schema and Jest validation.
- `azure-pipelines/publishSamples.yml` - production publication entry point for sample-query and permission files.
- `.github/workflows/handover-translations.yml` - translation handoff entry point for localized Graph Explorer messages.

---

Expand All @@ -135,12 +133,6 @@ The repository follows a content pipeline rather than an application service lay
| Azure Blob Storage | Receives published sample-query and permission artifacts from the production pipeline. | Not declared in this repository |
| Microsoft Graph documentation endpoints | Supply the `docLink` targets checked by the sample validation suite. | Not declared in this repository |

### Related Repositories

| Repo | Relationship | Purpose |
|------|-------------|---------|
| `microsoftgraph/microsoft-graph-explorer-v4` | Receives translated message files through `.github/workflows/handover-translations.yml`. | Hosts the Graph Explorer application that consumes the content. |

---

## Team Ownership
Expand Down