Add key_options/key_disposition support to create_*_key helpers#640
Open
benhillis wants to merge 1 commit into
Open
Add key_options/key_disposition support to create_*_key helpers#640benhillis wants to merge 1 commit into
benhillis wants to merge 1 commit into
Conversation
benhillis
force-pushed
the
reg-create-key-options
branch
from
fd100b1 to
07a859c
Compare
dunhor
reviewed
Jul 6, 2026
Comment on lines
+87
to
+95
| // Options controlling how a key is created. See the dwOptions parameter of RegCreateKeyExW. | ||
| enum class key_options | ||
| { | ||
| // The key is preserved when the system is restarted (REG_OPTION_NON_VOLATILE). | ||
| non_volatile, | ||
|
|
||
| // The key is not preserved when the system is restarted (REG_OPTION_VOLATILE). | ||
| is_volatile, | ||
| }; |
Member
There was a problem hiding this comment.
Ideally just assign these to their values and specify the size of the enum so this can just be a static_cast
Suggested change
| // Options controlling how a key is created. See the dwOptions parameter of RegCreateKeyExW. | |
| enum class key_options | |
| { | |
| // The key is preserved when the system is restarted (REG_OPTION_NON_VOLATILE). | |
| non_volatile, | |
| // The key is not preserved when the system is restarted (REG_OPTION_VOLATILE). | |
| is_volatile, | |
| }; | |
| // Options controlling how a key is created. See the dwOptions parameter of RegCreateKeyExW. | |
| enum class key_options : DWORD | |
| { | |
| // The key is preserved when the system is restarted (REG_OPTION_NON_VOLATILE). | |
| non_volatile = REG_OPTION_NON_VOLATILE, | |
| // The key is not preserved when the system is restarted (REG_OPTION_VOLATILE). | |
| is_volatile = REG_OPTION_VOLATILE, | |
| }; |
Extend the wil::reg create-key helpers so callers can request a volatile key and observe whether the key was newly created: - New key_options enum (non_volatile / is_volatile) mapped to the RegCreateKeyExW dwOptions parameter. - New key_disposition enum (created_new / opened_existing) surfaced via an optional out-parameter that mirrors lpdwDisposition. create_unique_key, create_shared_key, and their _nothrow counterparts gain defaulted options/disposition parameters, so existing call sites are unaffected. Adds RegistryTests coverage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
benhillis
force-pushed
the
reg-create-key-options
branch
from
b5860b0 to
c1e04f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
key_options(volatile) andkey_disposition(created vs opened-existing) support to thecreate_*_key[_nothrow]helpers. Includes Catch2[registry]tests passing in normal & noexcept configs. Part of enabling WSL to drop its in-house registry helper in favor of wil::reg.